This social module gets a Facebook News Feed via ID or name and shows it on your website in an iFrame. All privacy settings will be respected as the users can only see public contents, which every anonymous user is allowed to see.

Comments

iterator’s picture

iterator’s picture

Any feedback would be very much appreciated.

willvincent’s picture

Status: Needs review » Needs work

I've reviewed your code. A few issues jump out at me:

  • Code Formatting: Indents should be 2 spaces without tabs. (The majority of indents are 4 spaces)
  • CVS version Id string in translation file should be removed (Line 1)
  • javascript in tpl:
    • jquery plugin is dual licensed MIT & GPL, so it should probably be included with the module code, rather than included from the server based in Germany.
    • abouttheweb-drupal-fb-feed.js looks like it is hardcoded for that specific site? Again this should likely be included with the module code rather than included from the server in Germany.
    • The drupal_add_js() calls should probably be in the theme function or the _show_fbwall() function rather than in the template
  • Recommend using a div instead of the 'atw_stream' html element for potentially increased compatibility with non-html5 browsers.
  • Missing README.txt file

Perhaps a bit more clarification is also in order. It was unclear to me that this is only for facebook pages, and does not work with a personal profile, or facebook group. So, for example, I can't use it to display the newsfeed of my profile, or the wall of a public group, only the wall (newsfeed) of a PAGE. As such, it might be helpful to rename the module, and/or provide some clear documentation about this.

It also occurs to me that this is probably better suited to being a block than a page callback in the menu system. Although, I guess I could see it being useful as a page as well, so perhaps simply adding the block hooks to expose this to the block system.

Obviously, inclusion on any page through the theme layer wouldn't be too difficult, just have to ensure the .module is loaded and then print _show_fbwall(). That would probably be something worth including in the README.txt under an 'advanced usage' section or something.

misc’s picture

The applicant has been contacted to ask if the application is abandoned.

misc’s picture

The application has been closed. If you would like to reopen it, you are free to do so.
See http://drupal.org/node/894256

misc’s picture

Status: Needs work » Closed (won't fix)