When using the insert module, the images that get inserted with a Colorbox style don't have the style class that they get with non Colorbox styles.

I modified colorbox.theme.inc to fix it. A patch follows.

CommentFileSizeAuthor
#4 colorbox-insert-module-style-class-1180182-4.patch1.23 KBjox
#3 colorbox-insert-class-part2.patch1.22 KBfrjo
#1 colorbox-insert-module-style-class-1180182-1.patch562 bytesjox

Comments

jox’s picture

jox commented
StatusFileSize
new colorbox-insert-module-style-class-1180182-1.patch562 bytes
jox’s picture

jox commented

Here is an example to explain this more in detail:

Suppose a content type with an image field with insert button and two syles enabled: 'medium' and 'Colorbox medium'.

Now an image is uploaded, stlye 'medium' is selected and the insert button is pressed. The class attribute of the resulting img will include image-medium.

Now stlye 'Colorbox medium' is selected and the insert button is pressed. The class attribute of the resulting img will not include image-medium (nor something silmilar).

frjo’s picture

frjo commented
Category: bug » feature
StatusFileSize
new colorbox-insert-class-part2.patch1.22 KB

Could you please try this patch instead to se if it works for you?

It adds the image-[stylename] class and runs alla classes through drupal_html_class().

jox’s picture

jox commented
StatusFileSize
new colorbox-insert-module-style-class-1180182-4.patch1.23 KB

Great. Works fine, thanks.

One minor thing. I would name the variable $classes instead of $class, since it is an array that can contain multiple values. That would be just a little more meaningful naming. A modified patch is attached.

frjo’s picture

frjo commented
Status: Needs review » Fixed

Committed to 7-dev. Thanks for testing!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

zoo’s picture

zoo commented

Is there by any chance a fix which is back ported for the 6.x version of the colorbox module? Thank you!

kerios83’s picture

kerios83 commented

Great I have been waiting for this !