In order to avoid browsers such as IE reporting mixed http/https content, I added a small catch in the module to add http or https protocol to the google_service.js call depending on your current protocol method. This doesn't solve the problem of blocks being served in non ssl mode, but will help on pages where ads aren't served but you still require SSL. Hope someone finds it useful.

CommentFileSizeAuthor
#2 google_admanager-1180646-2.patch893 bytesjcisio
#1 google_admanager-1180646.patch1.38 KBdrumm
google_admanager.module.patch1 KBthezombieguy

Comments

drumm’s picture

drumm
he/him
Location NY, US
commented
Assigned: Unassigned » drumm
StatusFileSize
new google_admanager-1180646.patch1.38 KB

This is definitely needed. I'll be deploying the attached patch on https://association.drupal.org/advertising/web shortly. Newer versions of Google Chrome even block insecure scripts.

jcisio’s picture

jcisio commented
Status: Needs review » Fixed
StatusFileSize
new google_admanager-1180646-2.patch893 bytes

I committed the attached patch (using schemeless URI).

Automatically closed -- issue fixed for 2 weeks with no activity.