The help text for the issue tags covers the top two thirds commit message and commit message button, on 1024px screens. If this was just a visual thing, it wouldn't bother me, but it make it quite difficult to both click the button, and to select the text.

CommentFileSizeAuthor
#13 help-text-covers-commit-message_2.png109.58 KBnaught101
#13 help-text-covers-commit-message_3.png114.2 KBnaught101
#6 1180658-commit-msg-fix.patch524 bytesericduran
#4 dreditor-patch-ff4.png14.54 KBandypost
#4 dreditor-chromium.png15.41 KBandypost
#3 Screen shot 2011-06-06 at 7.48.14 PM.png30.47 KBericduran
#1 1180658-commit-msg-fix.patch785 bytesericduran
help-text-covers-commit-message.png21.39 KBnaught101

Comments

ericduran’s picture

ericduran commented
StatusFileSize
new 1180658-commit-msg-fix.patch785 bytes

I'm just pushing everything down by 1em. To account for the live break.

ericduran’s picture

ericduran commented
Status: Active » Needs review
ericduran’s picture

ericduran commented
StatusFileSize
new Screen shot 2011-06-06 at 7.48.14 PM.png30.47 KB

Screen shot of dreditor after patch.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new dreditor-chromium.png15.41 KB
new dreditor-patch-ff4.png14.54 KB

Works fine under ubuntu ff4 & chromium, same under win 7 ff5

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Needs work

I'd suggest to increase the padding-top on the wrapping DIV.comment-inner from 19em to 20em instead.

ericduran’s picture

ericduran commented
Status: Needs work » Needs review
StatusFileSize
new 1180658-commit-msg-fix.patch524 bytes

As per sun's recommendations

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Tested this on my browser/screen, seems to resolve the issue. However, would love to get a RTBC from someone who is affected by this bug (I'm not).

naught101’s picture

naught101 commented
Status: Needs review » Reviewed & tested by the community

Works fine for me.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Fixed

Thanks for reporting, reviewing, and testing! Committed to master.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

naught101’s picture

naught101 commented
Status: Closed (fixed) » Active

This is broken again with the recent d.o theme adjustments (I assume that's what happened). I haven't been arsed to actually debug it yet, sorry.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Postponed (maintainer needs more info)

Tried to reproduce, but works fine for me.

naught101’s picture

naught101 commented
Status: Postponed (maintainer needs more info) » Active
StatusFileSize
new help-text-covers-commit-message_3.png114.2 KB
new help-text-covers-commit-message_2.png109.58 KB

Here's two screenies. The first is the firebug overlay when there's one block in the right hand sidebar, the second is when I remove the 

.grid-8 {
    width: 620px;
}

Declaration, so that the main content column is full width. Both have the same problem, but for apparently different reasons... You can see the Xpath of the offending elements in the mouse-over.

My screen size is 1024x600, running FF5.0 on kubuntu 11.04

naught101’s picture

naught101 commented

Sorry, those images don't include the commit text, but the commit button is exactly the same height, and has the same problem.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented

Same problem here with FF 3.6 under Ubuntu.