The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Giving the l10n_client div the class "hidden" when it is not actually hidden but minimized is bad naming. This has lots of potential conflicts with other CSS, where hidden actually means hidden, i.e. "display:none" and/or "visibility:hidden". I recommend renaming this to "minimized" or something similar.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | l10n_client-1181356-6.patch | 2.34 KB | jody lynn |
| #4 | l10n_client-css_hidden.patch | 2.23 KB | Volx |
| l10n_client-css_hidden.patch | 2.17 KB | Volx |
Comments
Comment #1
afox commented+1 !
Tested working on the Feb 25th 6.x-2.x-dev
Comment #2
tsi commented+2
HTML5 Boilerplate and many other css frameworks (including my 965 theme) use "hidden" to actually hide elements.
This makes this module unusable with any of these frameworks, so I believe this is major.
Comment #3
jacineJust lost a couple of hours trying to figure this out as well. Can you please prefix the class name with the module name? I think
.minimizedis also too general.Comment #4
Volx commentedNo problem, here it is with "l10-client-" prefix :)
Comment #5
tsi commentedTested against 7.x-1.1, solves the problem.
This should get committed.
Comment #6
jody lynnReroll.
Yes, I found this issue because my theme hid the translation link and I had to debug it.
Comment #7
gagarine commentedPatch #6 add l10n-client-minimized but do not clean all hidden class..
EDIT I didn't say anythings.. I test it not on right branch.
Comment #8
gagarine commentedComment #9
SebCorbin commentedCommitted, thanks !
Comment #10
gábor hojtsyDoes this apply to Drupal 6? For backport :)
Comment #11
SebCorbin commentedYup, backported !