Variables should be declared for translation

sub

Thanks for the patch, works great.

Works, but I was also missing the node title option. Since this delivers the content, this should be multilingual too.

$variable['terms_of_use_node_title'] = array(
    'title' => t('Terms of Use node title'),
    'description' => t('The title of the node that the Terms of Use module uses'),
    'type' => 'string'
  );

I just discovered why this wasn't working. Until a patch is ready (I don't know how to do that), this is the solution:

file: terms_of_use.module
around row 58

$form['terms_of_use'] = array(
    '#type' => 'fieldset',
    '#title' => $fieldset_name,
    '#weight' => 10,
  );

Should be

$form['terms_of_use'] = array(
    '#type' => 'fieldset',
    '#title' => t($fieldset_name),
    '#weight' => 10,
  );

around row 112

$form['terms_of_use']['terms_of_use'] = array(
    '#type' => 'checkbox',
    '#title' => $checkbox_label,
    '#required' => TRUE,
  );

Should be:

$form['terms_of_use']['terms_of_use'] = array(
    '#type' => 'checkbox',
    '#title' => t($checkbox_label),
    '#required' => TRUE,
  );

Hope someone with a little more knowledge could make this to a patch:)

I made a patch from above.

(patch need to be applied using "git am < file.patch")

+1 works for me

Hi, thanks for the patch.

I tested it and I tried to translate my text with "@link" in the "label for the checkbox". It shows the HTML link in interface translation page. So I've done this patch to make translation available just for the text with "@link" and not with link that is already handled by the module itself.

Tests are welcome!

Thanks.

Ooops!... this #8 comment patch comes with the first patch

Hi

working with the variables module would be nice but I refuse a patch that can put strings in other languages than english into t() like the one in #5 is doing. Please reroll the patch with an update to the latest variables module so the strings can be translated.

#11 looks good and works for me.

#5 works for me, but not #11. Using 1.2.

According to this blog post, #5 should not be used.

I used #11 and it works. Just make sure:
1. Variable translation module must be enabled.
2. In admin/config/regional/i18n/variable , under "Other" subtab, mark the variable as translatable.
3. In /admin/config/system/variable/module, under Terms of use subtab, this is where you actually translate the variable.

Hope this helps

Like @bryanmanalo said (#14,) if you follow his short guide, you won't fail!

Hi,
I started with the patch of #11
But it doesn't cover the whole functionality. I extended it so the node id and title are also available as translated variables.

Because the administration was using AJAX to change the form elements and it was saving variables during form_validate the node_id translation wouldn't work.
I changed the flow of the form so the node id is a hidden value and it is only possible to apply the node with the node title.
During validate we then change the value of the node id.
So form submit can handle the multilingual variable.

This way it is possible to show a different node for each language.

Last patch does not apply against last dev

Tried patch #18 and now re-saved the module settings. Ran cron, flushed caches.
I get a new string for the admin description of the Label for the checkbox field. But the field itself is not translatable.

I thought it worked before, maybe i18n has gone through a change.... But I can no longer translate strings for this module, except for the one admin description this patch exposes.

Am curious as to what has happened...

Updating status

had another go at this and turned out i needed to enable the variable admin module to be able to translate the variable as per #15.

updating status

Needs to reroll the patch against the latest dev

Closed due to inactivity. If it is relevant, we will open it again