Needs work
Project:
UC Node Checkout
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
7 Jun 2011 at 18:33 UTC
Updated:
24 Jan 2013 at 22:26 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
snowmountain commentedI have seen the same message for products, and also after creating a product class for products of the new product class type. I have not been using node checkouts YET, so these products were also not uc_node_checkout products.
I do have UC Node Checkout 6.x-2.0-beta8 installed and enabled.
Thanks for the patch - I will be trying it out.
Comment #2
griz commentedHaving been implemented, the patch above no longer applies. However, I'm getting this problem again. I had a look and there is one tiny error: an "==" operand with only one "=" on line 823.
Patch attached.
-edit- actually, it doesn't work.
Looking into it >again<.
Comment #3
griz commentedOk, i *think* I've found the problem.
Shouldn't it be
$item->data['node_checkout_nid']Instead of
$item->data['nid']?Isn't it meant to be checking that the item is actually a node_checkout product? Otherwise it's just checking that the item has a nid. That will be true, but if the second condition is false it will throw the error, hence getting errors on every product which isn't a node_checkout product.
Comment #4
griz commentedHmm...
Try this.
Comment #5
vlooivlerke commentedthanks, it works
Comment #6
Anonymous (not verified) commentedIt looks like this patch is written for the dev version, is that correct?
Comment #7
Anonymous (not verified) commentedAlso - seems like I can't run the patch command on my server. Any chance you could attach the patched .module file please?
Comment #8
vlooivlerke commentedi used the dev version and patched it manually. it is only a few lines.
but here it is.
Comment #9
griz commentedYep, dev. There has recently been an update. Nothing has changed in the relevent part of the module, but here is another (slightly cleaner) patch anyway.
I know <TR> and Ryan are both very busy people... But any chance we could get this sorted?
Comment #10
GaryWong commentedApplying #9 against Node Checkout 6.x-2.0-beta8 and Cart 6.x-2.7, Drupal Core 6.22, resulted in:
I can just manually fix the .module (thanks vlooivlerke ) but thought I'd FYI this...
gary
Comment #11
benstallings commentedThanks to vlooivlerke for the fix in #8.
Comment #12
mattcasey commentedmanually patched... it works for me
Comment #13
aaronbaumanPatch #9 applies cleanly against -dev and fixes the issue from the OP.
RTBC, yeah baby!
Comment #14
aaronbaumanbump.
Comment #15
millionaire commentedI'm using 6x2 Beta 8 and all fixed thanks to vlooivlerke :)
Thank you!
Comment #16
stewart.adam commentedPatch in #9 may prevent the errors from being output but I don't think that it's correct; it removes the assignment of $uc_node_checkout_product and then references it in the if condition it adds, so that check will always fail.
Comment #17
aaronbaumanseems like most people on this thread would prefer to just remove the conditional altogether.
how about just logging it to watchdog, rather than displaying a user-facing message and fussing with the checkout pane?
Comment #18
mr.andrey commentedsubscribing...