Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.If you have just the wildcard, without any load, then rendering a link (either menu or tab) was broken. There was no example for this in core so it was not obvious. However, when I was writing docs and wanted to say that search tabs are not trivial then I realized that search redirects to search/node/foo hence search/node/% should be enough. The "when rendering a path that contains a % , replace te % with the actual argument" rule got lost, so I fixed it. This actually simplifies search.module and more exposes what _menu_translate does.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | tabs_fix_0.patch | 2.15 KB | chx |
| #4 | tabs_fix.patch | 2.49 KB | chx |
| simplify_tabs.patch | 3.5 KB | chx |
Comments
Comment #1
chx commentedComment #2
chx commentedFurther consideration tells me this is the best way.
Comment #3
chx commentedNeh! this , at the end of the day, does too much unneeded work with path. no, we need to store the empty match on building step (probably as FALSE) and then we will know which steps to perform.
Comment #4
chx commentedComment #5
chx commentedMinus the debugging chunk.
Comment #6
gábor hojtsyCoincidentally I just approached Karoly for a fix for this bug affecting locale module, so we can work on improvements for Drupal 6-dev. Tested this patch, and it seems to be working all fine on the locale interface. It fixes the funny display bugs which appear without this patch (sometimes the primary sometimes the secondary tabs are shown, but never both).
Comment #7
dries commentedCommitted. Thanks chx.
Comment #8
(not verified) commented