Node Page View Override Conflicts with Drupal Commons 2.2

This probably belongs in the Commons issue queue, right?

Page Manager will not override a menu item if some other item module has already done so. However, it is willing to allow modules to specify what the fallback should be. Modules can test if page manager is active and set to override that page; if it is, they can decline to do so and let Page Manager have it, and Page Manager will pass through to that module if no variant takes it. That's the only way I've found that seems to make cooperation actually work for everyone involved.

The hook is hook_page_manager_override() and its implementation looks like this for node_view:

  $function = 'node_page_view';
  foreach (module_implements('page_manager_override') as $module) {
    $call = $module . '_page_manager_override';
    if (($rc = $call('node_view')) && function_exists($rc)) {
      $function = $rc;
      break;
    }
  }

  // Otherwise, fall back.
  return $function($node);

This should be moved into the commons queue. I'm not quite sure which one that is just now.

Committed for fix for upcoming 2.0.

Came up with an interesting solution that seems fine to me:

/**
 * Implementation of hook_menu_alter()
 */
function commons_core_menu_alter(&$items) {
  $path = drupal_get_path('module', 'commons_core');
  
  // Override the node view callback in order to handle group home pages
  // For legacy support, do not override the node view if page manager
  // is already doing so
  $skip_node_override = FALSE;
  if (module_exists('page_manager')) {
    if ($task = page_manager_get_task('node_view')) {
      if (isset($task['disabled']) && !$task['disabled']) {
        $skip_node_override = TRUE;
      }
    }
  }
  if (!$skip_node_override) {
    $items['node/%node']['page callback'] = 'commons_core_node_page_view';
    $items['node/%node']['file'] = 'commons_core.overrides.inc';
    $items['node/%node']['file path'] = $path;
  }

Could the above fix be included in the next release of Commons?

Could the above fix be included in the next release of Commons?

There are 2 fixes above.

To help get this into Commons, it would be great if someone could test and verify which is the appropriate fix and provide a patch.

Wasn't this committed prior to the 2.0 release?

It's tough to tell without a link to the commit and without user verification of the fix before it was committed.

However, I found https://github.com/acquia/commons/commit/1b5c56f3328a9ff3bdde805c4bf544e... which is the solution in #4.

Based on the pinkonomy's feedback, it sounds like this isn't having the desired effect in Commons 2.2.

Perhaps Merlinofchaos' solution in #2 is the appropriate fix.

I'm having the same problem. Latest Commons version has the fix in #4, but it is not working properly - I am getting duplicate group images and duplicate featured group checkboxes. How do I test the #2 solution? Just paste it over the non-working one?

I can confirm that this is working properly, but is easily mistaken as a bug.

First, make sure that your page (in page manager) has been enabled. You can easily add a variant to the node/%node page in page manager, and forget to actually enable the page.

Second, remember that, despite turning on the newly created custom page, the contexts, which power the entire group page, will remain active - so you will get duplicate content. If you don't want the blocks appearing that context provides, be sure to disable them.

After taking that into considering, please retest, and let me know your results.

Thanks.

In my testing I'm able to override the page display for several content types within the latest dev of Commons. Marking this as fixed based on that testing and #12, but please re-open if you're still having issues overriding the node page view with Panels.