Discogs has announced API v2.0

Cool, thanks for this.

The lack of API key is awesome. I'm sure there'll be more to like.

Just in time for the D7 update, too. I already have to re-write much of the code, maybe now's the time to clean house.

EDIT: I think it is. The default format is now JSON, rather than XML. That is much more easy to implement in PHP. The only issue might be if the users don't have the PHP JSON library installed - but that's a requirement for D7 itself.

In the meantime, I'll fix up the D6 version to use the new API.

It is not yet updated. I will be able to work on that again after my finals are over.

I've been working on this for the past week or so. Nearly all of the import stuff has to be re-written.

I was also hoping to get a D7 version done before the next semester starts up, but we'll see if that happens or not.

Okay, hopefully this should be working now.

In addition to using the updated Discogs API, there is now an additional form page on import, where you can select the label/artist whose releases you want imported. You should see what I mean when you use the module.

Also, this module now REQUIRES PHP 5 or better, with JSON support - specifically, the json_decode() function. This is a requirement for D7, incidentally, and I'm pretty sure everyone has it by now. I had to do this, as the new Discogs API no longer returns XML, but returns JSON objects exclusively.

This is a pretty major rewrite, so undoubtedly there are lots of bugs I didn't catch. Nonetheless, I pushed it to the -dev version just now, hopefully it will propagate soon.

I am also attaching a patch.

Please tell me about any issues. If there aren't any, I'd like to use (roughly) the same code when I write the D7 version.

# 1 - note that the artist field gets imported with a trailing "/", e.g. "Phil Manzanera /"

Oops. Yeah, I was trying to make the theme_discogs_artists() function more efficient, and I broke it. I fixed that, and am attaching a patch.

By the way, you should probably create a new issue for each new problem. I'm going to go through the issue list and clean stuff up. A lot of it is really fixed, but I didn't get enough feedback to actually close the issue. (And a lot of it is simply overwritten with the new update.) I'm also going to create a new tag.

# 2 - there is no image preview for releases when confirming import

I didn't think there was one before... Did you override any of the theme functions? If so, maybe that got broken somehow? I'm really just guessing here.

Because of the changes to the API, most of the theme functions did have to change slightly. The function to create a single checkbox's text is theme_discogs_checkbox_text(). A URI to a thumbnail image (on Discogs' server) is included there, but I couldn't figure out a way to make it look even remotely passable, so I figured I would just leave it out and let individual designers override it if they want. All the available fields are documented in the function's comment block.

Anyway, if the issue is that the theme function doesn't work as before, create another issue for that and I'll look into it.

You're welcome.

I just found another bug to fix, so I'm not going to a 1.0 tag just yet, but it should be very soon.

I'm thinking that after 1.0, I will only be doing bug fixes, so I can concentrate on the D7 version.

Are there any other problems with this? If not, I'm going to close this issue and move on.

I am going to close this particular issue and move on.

However, right after you posted that, I found a (minor) bug that still needed to be fixed. D'oh! I did fix it, the patch is in the issue queue:
#1428150: Import data being stored with uid of 0