Download & Extend

Text Formats "configure" link links to "Edit" tab

Project:Drupal core
Version:7.x-dev
Component:filter.module
Category:bug report
Priority:minor
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

admin/settings/filters show operations 'configure' and 'delete'. 'configure' links to admin/settings/filters/1, which is the view tab. the configure tab is admin/settings/filters/4/configure.

It would be nice to have both 'configure' and 'view' listed as operations. But at the very least, the link should correspond to the text/label.

Comments

#1

Also to mention, on ?q=admin/settings/filters/1/list the help message is not seen. Therefore, whoever is going for a patch for this, include:

case 'admin/settings/filters/'. arg(3) .'/list:

below the line:
case 'admin/settings/filters/'. arg(3):

It was just another point out related to this. And also, can't "Rearrange" be changed to "Arrange"(atleast in D6).

#2

Title:configure links to view, not configure» Input Formats "configure" link, links to View tab

#3

I wonder if 'Order' is a better word here. 'Order' implies a linear series that goes 1 2 3 4. 'Arrange' is more of a 2 dimensional design/art concept, like layout -- at least by my understanding and usage of the words. Google seems to agree, but it's a bit subjective and wishy washy:

http://www.google.com/search?q=define:order
http://www.google.com/search?q=define:arrange

#4

Version:5.1» 6.x-dev

#5

Status:active» needs review

I created a patch which adds a 'view' operation and points 'configure' to the right page; the code from #1 is also included. I changed 'Rearrange' to 'Order', since the link is called 'admin/settings/filters/1/order'.

AttachmentSizeStatusTest resultOperations
filter.module_28.patch3.02 KBIgnored: Check issue status.NoneNone

#6

this patch fixes the help and instead of having a separate view link just adds a link to the filter's name.

AttachmentSizeStatusTest resultOperations
filter_118203.patch2.88 KBIgnored: Check issue status.NoneNone

#7

Status:needs review» needs work

Needs a re-roll.

#8

into the light again

#9

Version:6.x-dev» 7.x-dev

I haven't checked yet, but I assume this is still an issue in HEAD

#10

Title:Input Formats "configure" link, links to View tab» Text Formats "configure" link links to "Edit" tab

Updating title to reflect the D7 status

#11

Status:needs work» fixed

This bug no longer exists in HEAD.

#12

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here