admin/settings/filters show operations 'configure' and 'delete'. 'configure' links to admin/settings/filters/1, which is the view tab. the configure tab is admin/settings/filters/4/configure.

It would be nice to have both 'configure' and 'view' listed as operations. But at the very least, the link should correspond to the text/label.

CommentFileSizeAuthor
#6 filter_118203.patch2.88 KBdrewish
#5 filter.module_28.patch3.02 KBfwalch

Comments

Gurpartap Singh’s picture

Gurpartap Singh commented

Also to mention, on ?q=admin/settings/filters/1/list the help message is not seen. Therefore, whoever is going for a patch for this, include:

case 'admin/settings/filters/'. arg(3) .'/list:

below the line:
case 'admin/settings/filters/'. arg(3):

It was just another point out related to this. And also, can't "Rearrange" be changed to "Arrange"(atleast in D6).

Gurpartap Singh’s picture

Gurpartap Singh commented
Title: configure links to view, not configure » Input Formats "configure" link, links to View tab
Bevan’s picture

Bevan commented

I wonder if 'Order' is a better word here. 'Order' implies a linear series that goes 1 2 3 4. 'Arrange' is more of a 2 dimensional design/art concept, like layout -- at least by my understanding and usage of the words. Google seems to agree, but it's a bit subjective and wishy washy:

http://www.google.com/search?q=define:order
http://www.google.com/search?q=define:arrange

Gurpartap Singh’s picture

Gurpartap Singh commented
Version: 5.1 » 6.x-dev
fwalch’s picture

fwalch commented
Status: Active » Needs review
StatusFileSize
new filter.module_28.patch3.02 KB

I created a patch which adds a 'view' operation and points 'configure' to the right page; the code from #1 is also included. I changed 'Rearrange' to 'Order', since the link is called 'admin/settings/filters/1/order'.

drewish’s picture

drewish commented
StatusFileSize
new filter_118203.patch2.88 KB

this patch fixes the help and instead of having a separate view link just adds a link to the filter's name.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Needs work

Needs a re-roll.

Gurpartap Singh’s picture

Gurpartap Singh commented

into the light again

Bevan’s picture

Bevan commented
Version: 6.x-dev » 7.x-dev

I haven't checked yet, but I assume this is still an issue in HEAD

matt2000’s picture

matt2000 commented
Title: Input Formats "configure" link, links to View tab » Text Formats "configure" link links to "Edit" tab

Updating title to reflect the D7 status

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Fixed

This bug no longer exists in HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.