Now, the page titles settings is requiered. I think, this doesn't necessary. Why should force overwrite core page titles? Well, the original problem was the support of translation in #1182188: Text variables translation .

I think, only need to change page titles, if user want.

In this patch, I removed the two validation function, and set NULL as default value's of page titles.

CommentFileSizeAuthor
#1 required-page-title-1182192-1.patch15.02 KBszantog

Comments

szantog’s picture

Status: Active » Needs review
StatusFileSize
new15.02 KB

And the patch

lelizondo’s picture

Title: Required page titles » Page titles should be optional, not required.
Category: bug » task

This is actually the right approach, although I don't see this like a bug since nothing is broken. The suggestions are exactly as drupal would do it as default, but again, this is a nice patch. I'll test it and if it works, I'll commit.

Thanks.

szantog’s picture

Ups, sorry, this isn't bug in dev version, because the title translation is now working.

  • ksbalajisundar committed 0fcf531 on 6.x-3.x
    Issue #1182192 by ksbalajisundar: Page titles should be optional, not...
kssundar’s picture

Issue summary: View changes

Ported to 6.x-2.x

kssundar’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.