Now, I'm using this module with In-place translation This module clones node form field's, but ignored this module's settings. I hesitated, in what module should I work.. The most important aspect to create patch for this module: This seems more maintained. The second is: This module's settings, this module force it. :)

I changed these_
# modified: includes/option_nfs_inputformat.inc
# modified: includes/option_nfs_splitsummary.inc
# modified: includes/option_nfs_submission_body_rows.inc

I hope, nothing missed.

CommentFileSizeAuthor
#1 ipetrasnlation_comp_1182734_1.patch2.97 KBszantog

Comments

szantog’s picture

szantog commented
Status: Active » Needs review
StatusFileSize
new ipetrasnlation_comp_1182734_1.patch2.97 KB

And patch

lelizondo’s picture

lelizondo commented
Status: Needs review » Needs work

I never used that module. What is exactly what it does? Does it translate fields also and NFS is just not recognizing those translations?

This sounds like it could work, unfortunately, the patch needs work, since you're removing what I think are essential parts of this NFS that without them, NFS will *need* ipetranslation to work.

What you could do is wrap everything inside:

<?php
if(module_exists("ipetranslation")) {
 // more code here ...
}
?>

but not remove anything else unless the module will work, with or without ipetranslation

szantog’s picture

szantog commented
Status: Needs work » Needs review

No, I don't remove anything, I don't change anything, I've just completed your codes with if (module_exists.. part) :)

The problem is the next with ipetranslation:

I have 3 language. The ipetranslation changes the node add/edit form. All three language fields in one form. Well, there are 3 title, and 3 body field. Without this patch only the original language fields accept the nfs settings. If I set the body row 3, and I'm on node/add form, only the default languages body field has 3 line body, the others are default.

Let's see this pictures:

Default: http://img714.imageshack.us/img714/7573/kijells015.png

With patch: http://img811.imageshack.us/i/kijells014.png/

The core has a form item body_field, the ipetranslation creates own body field for all langauge like this: body_field_[LANG_CODE].

My patch completes your default body transformations, if ipetranslation installed, transform the other language all body_field_[LANG_CODE] too.

What you see as remove,
- return $form;
it isn't neccessary, because the $form parameter is with &
function _option_nfs_inputformat(&$form..

lelizondo’s picture

lelizondo commented

My bad. I'll take a deep look into it.

  • ksbalajisundar committed 723afbc on 6.x-3.x 
    Issue #1182734 by ksbalajisundar: Compatible with ipetranslation module.
kssundar’s picture

kssundar commented
Issue summary: View changes
Status: Needs review » Fixed

Ported to 6.x-3.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.