Contexts, arguments and relationships for entities, need view_mode and language settings that can be passed down to the fields they support. This will require the entity_field, entity, entity_id, and various entity based relationship plugins to be updated pretty significantly.

CommentFileSizeAuthor
#5 language.diff1.41 KBeclipsegc

Comments

eclipsegc’s picture

eclipsegc commented
Status: Active » Needs review

Ok, I think this is ready for some review, can be found on my ctools sandbox:

git clone --branch entity-view-modes http://git.drupal.org/sandbox/eclipsegc

Relevant Commits:
http://drupalcode.org/sandbox/eclipsegc/1073402.git/commitdiff/3782ff022...
http://drupalcode.org/sandbox/eclipsegc/1073402.git/commitdiff/8c89b8b3c...
http://drupalcode.org/sandbox/eclipsegc/1073402.git/commitdiff/bed07579f...

eclipsegc’s picture

eclipsegc commented

Explanation for the rationale for all of this can be found in the commerce queue #1182712: Page Manager Integration (postponed pending a ctools patch)

courtney.mob’s picture

courtney.mob commented

subscribe

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Needs work

'und'

There is a define for this, something like LANGUAGE_NONE (I forget exactly). We should use that over 'und'.

eclipsegc’s picture

eclipsegc commented
Title: Add view mode and language settings to contexts » Start creating a usable language.inc in ctools
StatusFileSize
new language.diff1.41 KB

After a lot of reflection, I've chosen not to do it this way, the entity field plugin should probably specify a build_mode instead: #1365648: Entity_field content_type needs to be able to set a view_mode.

The language include in this is useful though, so I've kept it and updated this issue accordingly.

eclipsegc’s picture

eclipsegc commented
Status: Needs work » Needs review
merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Looks reasonable.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.