The current menu item should be switched as soon as possible, otherwise, for instance, context menu-based conditions might not behave properly.

CommentFileSizeAuthor
#1 i18nmenu_node-1183692-1.patch735 bytesplach

Comments

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Active » Needs review
StatusFileSize
new i18nmenu_node-1183692-1.patch735 bytes

The attached patch moves the menu item update from hook_node('view') to hook_init().

finex’s picture

finex commented

The patch looks fine

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

We need extensive testing of this before committing, so we are sure nothing breaks. Did you test it?

finex’s picture

finex commented

I'm doing some tests with context and at this moment conditions based on menu items works fine (with i18nmenu_node enabled + this patch)... anyway I've not had any problem without the patch :-p

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs review » Fixed

I tested this in a project of mine with pretty advanced use cases and I'm pretty confident this should not break things. Let's open this to wider testing.

Committed to HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.