When user role gets deleted, transitions table still contains this role ID which causes an extra table row to appear in permissions fieldset along with PHP notice.
Patch attached.

CommentFileSizeAuthor
workflow.admin_.inc_.patch1.68 KBevgeny.chernyavskiy

Comments

johnv’s picture

johnv
Primary language Dutch
commented

D7 contains hook_user_role_delete($role)

johnv’s picture

johnv
Primary language Dutch
commented
Version: 6.x-1.x-dev » 7.x-2.x-dev
Assigned: evgeny.chernyavskiy » Unassigned
Issue summary: View changes
Status: Needs review » Fixed

The provided patch corrects the database when the permissions page is shown. But the page may never be called.
ersion 6.x will not be corrected anymore.
I corrected the page in 7.x-2.x with this commit.

johnv’s picture

johnv
Primary language Dutch
commented
Status: Fixed » Active

To resolve the root cause, we must take the provided patch, and moved to a new D7-call to hook_user_role_delete($role)

johnv’s picture

johnv
Primary language Dutch
commented
Status: Active » Closed (won't fix)

With the D7-changes in the pages, the reported messages do not appear anymore.
The role is still in the workflow_transitions table, though.
But implementing hook_user_role_delete($role) requires too much code and work to resolve that minor issue. Especially since the role is removed the next time someone hits the transitions config page. (which is implemented the provided patch.)

So, make this a won't fix.

Thanks for reporting, it hinted me to another problem: #2228317: hook_user_role_insert is not called when Admin UI disabled.