Forgive my cluelessness - I also posted on the documentation pg: I've been using marinelli-7.x-3.0-beta10 with a customized sub-theme, but when I updated the main theme to marinelli-7.x-3.0-beta11 this morning I got all kinds of errors ("Missing argument 4 for marinelli_c_c") on the site. I rolled back, but would like to know what went wrong, if it's a bug or if I messed up something in the update process, and how to do it properly. I have been searching, but haven't yet found a list of steps I might have missed.

Thanks!

Comments

dustinface’s picture

I too am having the same type of issues. I have customized the Marinelli theme I had and when I made the update, it gave me every error under the sun. It not showed me my custom theme but also the original theme as well (both layouts were basically merged). The biggest was the error was apparently in the template.php script because that was the error that was posted directly on my Home page. The new theme lost much of my changes and I reverted back to the older version. If I have more time, I may compare the two versions of code to figure out where the problem is, but until then I wont update the new theme again.

mavimo’s picture

@agerard try to resave theme settings configuration (see #1180832: Undefined index: image_weight in marinelli_get_banners() ) and let us know if it solve your problem.

jg-staffel’s picture

+1
@mavimo - #1180832: Undefined index: image_weight in marinelli_get_banners() - it not solve our problem.

mavimo’s picture

Assigned: Unassigned » mavimo
Category: bug » support

If you customized phptemplate_preprocess_page() function into template.php file try to check if you have:

// stores single sidebar presence into a variable
$vars['exception'] = "";
if ($vars['page']['sidebar_second']) {
  $vars['exception'] = 2;
}
else if($vars['page']['sidebar_first']){
  $vars['exception'] = 1;
}

this is required into templates/page.tpl.php.

I think is not a bug, but you must change your subtheme to respect marinelli teme change. Let us know if that solve the issue.

agerard’s picture

I didn't customize phptemplate_preprocess_page(), only specified (and located) a subtheme in the usual way to have a site-specific banner. Unfortunately, I have to keep the site available - and can't essentially render it useless to keep trying random fixes that don't seem to be working for others or don't seem to apply. Like dustinface, I will have to wait and see.

mavimo’s picture

Do you have copy page.tpl.php template file into your theme?

agerard’s picture

I copied the whole templates dir. so yes, it's in there. I did modify it by adding an "if" around the breadcrumbs rendering, but isn't that why we have subthemes?

mavimo’s picture

@agerard: no, you don't need to copy the whole templates dir (or CSS, JS, ...) into your subtheme, you can just sxplain (into info file) you are using a subtheme (see: http://drupal.org/node/441088 ) . I think you can easy solve your problem by copy page.tpl.php and re-add your if.

PS: you can also do not copy page.tpl.php but using theme_preprocess_breadcrumb into your template.php.

avoura’s picture

I am having the same problem, and getting the following error message:

Warning: Missing argument 4 for marinelli_c_c(), called in /home/xxxx/public_html/sites/all/themes/marinelli/templates/page.tpl.php on line 121
and defined in marinelli_c_c() (line 133 of /home/xxxx/public_html/sites/all/themes/marinelli/logics/layout.inc).

I don't know how to fix it, but at least I know I am not the only one after this was upgraded.

Would just copying the old files back to the server solve the problem or would it cause other problems?

avoura’s picture

The Marinelli description page has this info:

"

beta-11 upgrade notes

If you upgrade from marinelli-3.0-beta10 to marinelli-3.0-beta11 please resave your theme settings from page Apparence » Marinelli » Settings to remove warning appairs. Please see #1180832: Undefined index: image_weight in marinelli_get_banners() for more info."

I looked in Admin/System/Appearance/Marinelli/Settings and could not find any way to remove warnings. Not sure what the author meant by "appairs" though.

Anyone have any ideas?

mavimo’s picture

@avoura Re-SAVE you theme settings and warning desappair :P

avoura’s picture

I have tried doing that several times, but nothing changes. The warnings still appear.

mavimo’s picture

Status: Active » Reviewed & tested by the community

@lioz : it work fine, please commit it.

avoura’s picture

Status: Reviewed & tested by the community » Active

Update: As there seems to be no fix for the problems I had, I have reverted my site back to beta10 as it was before, and now the error messages do not appear.