Currently, if an exception is thrown when generating a block, a huge horrible fatal error is generated. Really we don't need to have anything quite that exotic. Why don't we put a try/catch around the block generation and not render the block (and emit a regular _drupal_log_error() or something) so that the administrator gets the information, but we don't deliver a full fatal error for every page where the block is to be rendered.

CommentFileSizeAuthor
#2 commerce.catch_exceptions_1184138_02.patch7.6 KBrfay
#1 1184138-block-exceptions.patch2.39 KBdamien tournoud

Comments

damien tournoud’s picture

damien tournoud commented
Status: Active » Needs review
StatusFileSize
new 1184138-block-exceptions.patch2.39 KB

Suggested patch.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Title: Catch exceptions when building all blocks » Catch exceptions for render/entity failures
StatusFileSize
new commerce.catch_exceptions_1184138_02.patch7.6 KB

Working the queue, I notice the other place that's crucial in this regard is rendering a product reference. This patch adds a try/catch around the product reference view in commerce_product_reference.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

We really really still need to handle this situation.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs review » Needs work

Doesn't apply any more and the merge requires brainwork. Marking CNW

jsacksick’s picture

jsacksick commented
Issue summary: View changes
Status: Needs work » Closed (outdated)