Hi

I get this error in Drupal 7 when I went to "admin/settings/delete_orphaned_terms"

CommentFileSizeAuthor
#10 delete_orphaned_terms-field_attach_query-1184464-7.patch1.79 KBnlisgo
#3 delete_orphaned_terms-field_attach_query-1184464-3.patch1.52 KBnlisgo

Comments

Mamouri’s picture

Mamouri commented

+1

nlisgo’s picture

nlisgo commented

Drupal 7 API Change notification: field_attach_query() removed

http://www.devheads.net/web/drupal/development/development-drupal-7-api-...

Need to use EntityFieldQuery instead. I'm checking it out. I'll prepare a patch if I get it to work.

nlisgo’s picture

nlisgo commented
Assigned: Unassigned » nlisgo
Priority: Normal » Critical
Status: Active » Needs review
StatusFileSize
new delete_orphaned_terms-field_attach_query-1184464-3.patch1.52 KB

I am submitting a patch that swaps out any instance of the field_attach_query function and uses instead EntityFieldQuery.

I can confirm that applying this patch will make the module work. field_attach_query has been discontinued.

TimelessDomain’s picture

TimelessDomain commented
Status: Needs review » Reviewed & tested by the community

it works! thanks.

nlisgo’s picture

nlisgo commented
Status: Reviewed & tested by the community » Patch (to be ported)

Can we get this patch accepted!!

nlisgo’s picture

nlisgo commented
Status: Patch (to be ported) » Reviewed & tested by the community

Can we get this patch accepted!!

soulston’s picture

soulston commented

This works for me although I do get a PHP Notice:

Notice: Undefined property: stdClass::$id in _delete_orphaned_terms_voc_is_tag() (line 115 of /Users/spoulston/Sites/Development/drupal-7.7/sites/all/modules/delete_orphaned_terms/delete_orphaned_terms.module).

MGParisi’s picture

MGParisi commented

subscribe

MGParisi’s picture

MGParisi commented

tested, fixes most issues but not #7

Is this Abandoned?

nlisgo’s picture

nlisgo commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new delete_orphaned_terms-field_attach_query-1184464-7.patch1.79 KB

This should fix the PHP Notice in #7 too.

nlisgo’s picture

nlisgo commented

Unfortunately it does appear to be but it's a useful module. I've needed it a few times!

matt v.’s picture

matt v. commented
Status: Needs review » Fixed

@nlisgo Thanks! I've now committed the patch. I'll make a beta release next.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.