Adding rel="author" to "Submitted by" link

If I'm correct this is html5 only? Adding a tag.

Is rel=author valid xhtml 1.0?

What about when user is rendered outside of an authoring context? Does Who's online, or Who's new, use the same preprocess for User?

Drupal 8 will be html5, but is also going to need to be able to fallback to valid xhtml 1.0, so however we add this, we are going to need to make sure it is easily removed.

Have you looked at either:

1. What can be done in hook_preprocess_node(), where the name is being used in the context of authorship
2. adding a boolean variable to $variables that can be set to true when the username is being rendered in an authorship context

#17: adding-author-to-submitted-by-link-1184472-15.patch queued for re-testing.

Thats a broken test

+++ b/includes/theme.incundefined
@@ -2576,8 +2576,15 @@ function template_preprocess_username(&$variables) {
+    // If we are in authorship context
...
+      // Adding attributes for the link to local user

redundant comment?

12 days to next Drupal core point release.

I haven't read through the comments, just the patch. I'm not sure why we are adding a line to set title twice?

+    if (isset($variables['authorship'])) {
+      // Adding attributes for the link to local user
+      $variables['link_attributes'] = array('title' => t('View user profile.'), 'rel' => 'author');
+    }
+    else {
+      $variables['link_attributes'] = array('title' => t('View user profile.'));
+    }

This should be:

+    $variables['link_attributes']['title'] = t('View user profile.');
+    if (isset($variables['authorship'])) {
+      $variables['link_attributes']['rel'] = 'author';
+    }

:-)

The way it's now, I don't think it's future-proof enough..

Instead of

$variables['authorship'] = true;

it should be something like:

$variables['username_rel'] = 'author';

That way, you can actually set the rel tag to something other than 'author' simply by setting the value to something else.. Drupal could even start to support XFN natively :)

And it needs a test..

I think I see a problem in #27. $variables for hook_preprocess_node is different than the variables for hook_preprocess_username. So while you're setting $variables['username_rel'], that key is not available when you're checking it in the hook_preprocess_username.

The only way I'm able to get rel="author" to show up is to remove the if statement altogether, undermining the ability to set the author attribute in the specific, applicable instances.

I'm trying to think if there is another way to do this...

There seems to be an issue of context... and I'm not sure how easy it'll be to for the theme_link theme to know that context at the block level.

Agree with #30. rel=author is only applicable in an authoring context, e.g. the display of a node.

@ralt

I expect that testing that the attribute exists, and is set to author is a reasonable test.

Ralt. I totally understand when it's only in the node itself. What I found in my digging is that the function used to render said link has no idea if it's being rendered within a node versus some other page element.

Case in point. I applied your patch and then went to a node with the "who's online" block to the left. In the patch, it's using node_preprocess to add an key to the $variables array and then using the variable to check in the username preprocess function to determine if we're in the node.

The problem is that nodes $variable array is not the same passed to the username function, and thus that if control statement returns false everytime based on my testing.

I totally understand the context when it should be added. What I'm trying to figure out is the best way to pass the hook_preprocess_username the variable necessary to alert it that it's within a node and thus should use the rel="author" tag.

@Ralt: nice to adopt the definition I suggested, but the objective is to use the content of the variable also...

$variables['link_attributes']['rel'] = $variables['username_rel'];

Or else, you gain nothing from changing it from the previous 'true' value.

I've slightly modified your patch to make it even more extensible. Notice the use of an array, so that more than one rel value can be set (i.e. rel="author me").

#34: adding-author-to-submitted-by-link-1187442-33.patch queued for re-testing.

Only #34 reroll

My point was that the variables being set in template_node_preprocess are not made available in template_preprocess_username and thus it may never validate as true and add the rel="author" information.

But I'll check against #38 to see if there was another way around this based on the suggestions of jcnventura

#37 does not work because the template_preprocess_username does not have the $variables['username_rel'] variable passed to it.

Wow, template_preprocess_username, theme_username and template_process_username are absolutely disgusting.

Here's a fixed patch.... Would be good to clean those functions up though, they're so gross to work with.

Updated for #22336: Move all core Drupal files under a /core folder to improve usability and upgrades - reviewed with patch applied and noted use of rel="author".

renaming patch - I don't know why this is failing - works on localhost.

resubmitting patch (this has wrong EOL conversion). stumped - am curious what the fix would be.

I'll take a look after turkey. If I can't knock it out this weekend I'll unassign.

This should fix it ...

Yup! That does it.

Committed to 8.x. Thanks.

Hello, where do you upload this file?

Can this be backported to D7? If not, how does one achieve the same thing? ...in the theme level perhaps? Is there any contrib D7 module that takes care of it?

PS: I might be asking this question here for D7, but I'm sure people would want to know the same for D6 too.

this definitely *could* be back-ported ... but I suspect that Dries/Webchick would consider that an API change (albeit minor) and wouldnt agree to commit it

If you want to achieve something like this in D7 you could always write a mytheme_preprocess_node(&$variabels) function & mytheme_preprocess_username(&$variables) function in your template.php file and then just follow the same basic idea as the patch in #53

Thanx Alexander. ...still digesting your pointers :/

Any chance for someone to provide a code snippet ready to go in the template.php file (or a D7 contrib module perhaps)?

UNTESTED, but something like this should work (put it in template.php):

function mytheme_preprocess_node(&$variables) {
  $variables['name'] = theme('username', array(
    'account' => $node,
    'link_attributes' => array('rel' => 'author'),
  ));
}

function mytheme_preprocess_username(&$variables) {
   if ($variables['uid'] && $variables['profile_access']) {
     // We are linking to a local user.
    $variables['link_attributes']['title'] = t('View user profile.');
   }
   elseif (!empty($account->homepage)) {
    $variables['link_attributes']['rel'] = 'nofollow';
   }
}

...well sticking the two functions at the end of the core Garland theme's template.tpl (renaming mytheme_* to garland_* and removing the wrapping php tag of course) simply gives me a WSOD :/

...garland already has a garland_preprocess_node function, so I moved the code from the one you provided in it. That got rid of the WSOD. Also had to change &$variables to &$vars. After making sure I cleared caches, still Google's Rich Snippets Testing Tool sees no authorship markup in my pages.

...and inspecting the link:

<a class="username" title="View user profile." href="/my-site/el/user/1">admin</a>

...here it is:

Notice: Undefined variable: node in garland_preprocess_node() (line 123 of /var/www/my-site/themes/garland/template.php).

line 123 is 'account' => $node, of course.

Don't know why this didn't come up before with all the page refreshes & cache purging :?

...garland_preprocess_node

function garland_preprocess_node(&$vars) {
  $vars['submitted'] = $vars['date'] . ' — ' . $vars['name'];
  $vars['name'] = theme('username', array(
    'account' => $node,
    'link_attributes' => array('rel' => 'author'),
  ));
}

...moving the line so that $vars['submitted'] is set after $vars['name']

function garland_preprocess_node(&$vars) {
  $vars['name'] = theme('username', array(
    'account' => $node,
    'link_attributes' => array('rel' => 'author'),
  ));
  $vars['submitted'] = $vars['date'] . ' — ' . $vars['name'];
}

Now the submitted info when the node is rendered replaces the actual username link with plain text "Anonymous (not verified)":

Fri, 02/10/2012 - 18:07 — Anonymous (not verified)

Will try to get some sleep and fight this a bit more once my brain is back in place :p ...I'll probably open a new support request against D7 so I don't add noise here any more - sorry people.

...filed #1444856: D7: how to add rel="author" to the "Submitted by" link? as a support request.

thanks for this info , helpful me