Comments

johnennew’s picture

Issue tags: +image, +target
StatusFileSize
new163.26 KB

Thanks! I've not got it promoted out of sandox yet so I've attached the current version to this post for interested people to have a go. All feedback welcome!

artatac’s picture

Oops I tend to just build in d7 now but will gladly test it out
Regards
Joe

zeezhao’s picture

Title: Sounds great » D6 Image Target Question - not showing up

Hi. I got it installed, but each type I try and create "Image Target Question" via an existing quiz, it jumps to node/add page and can not find "Image Target Question" there... Please confirm that version in the repository works. I am running drupal 6.16 on php 5.2.6 with quiz 6.x-4.2. Thanks

zeezhao’s picture

Title: D6 Image Target Question - not showing up » D6 Image Target Question

Upgraded to drupal 6.22, and it now shows up! Will test it out. Thanks

zeezhao’s picture

Tried it out. The only issue I have now is that it does not score the answers correctly. Even though cross-hairs are moved onto correct regions, it still says all are incorrect!

Do I need specific versions of jquery, etc? Please confirm. Thanks

zeezhao’s picture

Ok. Got it to work but on an older version of quiz from 2010-09-17... So issue really is that it does not work on newer versions of quiz module. Looks good! Thanks.

Would be nice to get it to work with latest quiz 6.x-4.3., and also D7 7.x...

edit: it seems jquery_update is what is clashing with it, not latest quiz.

zeezhao’s picture

Also found that it may cease to work depending on version of jquery_update.

Please confirm the correct versions required. Thanks.

johnennew’s picture

Hi, Thanks for your feedback zeezhao .

I've not looked at this for a while as not had much call for it. Will look at it now and get back to you - there probably are odd dependencies which I'll need to address as I've only tried it for my specific case.

Nice to see someone else wants it though.

John

zeezhao’s picture

Thanks. Will await feedback.

By the way, you should also get the module mentioned on the quiz homepage as a "Quiz Addon".

johnennew’s picture

StatusFileSize
new160.04 KB

Hi,

There is a new version of the Drupal 6 module in the git repository. I have tested with Quiz 4.3 and jquery_ui version 1.5 and using jquery ui version 1.6 and seems to work fine. I have not tested with jquery_update. Can you let me know if there are any issues? Also what errors are you seeing with jquery_update. Is it the module or that it is using a later version of jquery than the D6 default version.

Attached is a gzip version

Also, this is a fairly big rewrite so I recommend uninstalling the old version before switching on this one.

Kind regards,
John

zeezhao’s picture

Thanks - will try it out soon.

With regards to the older verion, issues I had before relating to jquery_update module clash were:
1. on one drupal installation, anytime you clicked to create "image target question" it jumped to "node/add" page instead of opening creation form.

2. On another drupal installation, it did not score the answers correctly. Even though cross-hairs were moved by user onto correct regions, program still said all were incorrect at feedback time. So I started with a clean drupal 6 install, and worked my way from there, and found that once I added jquery_update module 6.x-2.0*, the problem started.

zeezhao’s picture

Did a quick test on new version - it works, although there is an error in logs due to a missing js file:
- go to admin/reports/dblog:

page not found .... sites/all/modules/imagetarget/js/imagetarget.js

Its due to:

theme/imagetarget.theme.inc:  drupal_add_js($path . '/js/imagetarget.js', 'module');

So maybe this file is no longer required anymore? Please confirm.

edit:
One more thing I noticed is that after adding an image question to an existing quiz, the process does not return you to the quiz questions. I think the older version did so?

johnennew’s picture

StatusFileSize
new174.99 KB

Hi zeezhao,

Thanks for looking at this. I have removed the problem you reported with the missing JS and have now made the module compatible with jquery_update. If you use jquery_update you have to use version 1.7 of jquery_ui. Instructions on how to update are included in the jquery_ui README.txt

Please let me know how you get on!

Kind regards,

John

zeezhao’s picture

Hi. Thanks fro the new version. Did a quick run on latest version.

I works but still have these issues:
- error in logs file "Unable to save uploaded file." even though image is loaded.

- after adding an image question to an existing quiz, the process does not return you to the quiz questions page.

I have not been able to test the jquery_update yet, as that issue was on another installation.

johnennew’s picture

StatusFileSize
new160.55 KB

Hi zeezhao,

Thanks for continuing to test this module. I have fixed the "Unable to save uploaded file" dblog problem.

I could not replicate not being returned to the manage questions screen after editing a question. This may have been fixed already but if not can you describe the steps to replicate? I was going into a quiz, clicking manage question, adding a new image_target_question then pressing save and I was brought back to manage questions.

There have been some changes so maybe you need to uninstall the module completely then re-enable?

Kind regards and thanks again,

John

You can get latrest code from git or I have attached latest as a tar.gz in case thats easier for you.

johnennew’s picture

Assigned: Unassigned » johnennew
Status: Active » Needs review
zeezhao’s picture

Hi.

1. This latest version is different for what you have in git e.g. js directory missing.

2. Both latest versions (git & image_target_question.tar_.gz ) don't work on clean installation as tables are not getting installed. Please confirm that you have loaded the latest working code. Getting:

user warning: Table 'learn.quiz_image_target_question_properties' doesn't exist query: INSERT INTO quiz_image_target_question_properties (nid, vid, fid, width, height, feedback, feedback_format) VALUES (9, 22, 8, 237, 410, '', 1) in ... \sites\all\modules\image_target_question\image_target_question.classes.inc on line 64.

and so on...

3. I also noticed you have changed module/table names from *imagetarget* back to *image_target_question* . Please confirm.

zeezhao’s picture

Fyi - Looks like installation issue may be related to having first image_target_question module, then imagetarget, then back to image_target_question. It seems to install fine on a new drupal installation.

Will run tests again over the next couple of days.

johnennew’s picture

Thanks zeezhao. It is going to be image_target_question from now on. I was having a coding standards debate with someone on the project applications queue to get this promoted out of sandbox and that is what we went with. Sorry about that.

Kind regards,
John

zeezhao’s picture

Ok. I have tested the version in #15 and it looks fine. Thanks for this. You should load that into git as when I checked last week, the versions seemed different.

johnennew’s picture

Thanks zeezhao,

The 6.x-1.x branch should be up to date. I did have old code in the master branch which you may have checked out. The master branch now has had everything removed from it as master is not supposed to contain anything as per Drupal conventions.

There is now a D7 version of Grouping question and I'm about 50% of the way through converting image target to D7 as well.

Kind regards,

John

johnennew’s picture

Version: » 6.x-4.3-beta1
Status: Needs review » Closed (fixed)