Nodequeue support (plugin)

Hello,
I've tried your patch. While all of the syntax checks out just fine, nothing is happening on the frontend when I add items to, remove items from, or re-order a nodequeue. All of my views Content Cache settings are set to "none" for min/max lifetime. I've tested every way I can think of.

views_content_cache_update_set($subqueue, 'nodequeue'); is executing and returning a 1, but my output on the frontend never changes.

As a followup, I discovered a problem... the parameters for hook_nodequeue_sort_alter() have been reversed in 6.x-2.11. So, for use with nodequeue 2.11:

views_content_cache_nodequeue_sort_alter($sqid, $nodes)

becomes

views_content_cache_nodequeue_sort_alter($nodes, $sqid)

See http://drupal.org/node/1212876#comment-4709402

I'm going to continue testing to see what else might be keeping this from working for me.

Hey again,
Unfortunately I never got your code to work 100%. I discovered the parameter swap during my investigation, but didn't devote too much time to figuring out why else it may not be working for me.
If I find some time I'll dig back into it again.
Cheers!

Hey all, with the fix,

views_content_cache_nodequeue_sort_alter($sqid, $nodes)
becomes
views_content_cache_nodequeue_sort_alter($nodes, $sqid)

and nodequeue 2.11 this works like a charm. Thank you so much for putting this together and sharing it!

We are now using it on the main top story display at globalpost.com and it's allowing our cache to be significantly more responsive.

Thank You!!

Patch from #7 applied cleanly to Dev branch... sorry, I mis-tagged this comment.

+1 for this! It worked here!

Thank you all!

Patch looks good, but need to get tests passing before I can merge in.

Thanks so much, merged in 6.x-2.x

tried with views_content_cache 7.x-3.0-alpha2, i get any error but the cache is not flushed.

EDIT: Ops, my fault, I had not seen the option in the View Configuration. Great patch!

Getting this warning:

Strict warning: Declaration of views_content_cache_key_nodequeue::options_form() should be compatible with views_content_cache_key::options_form($value, &$handler = NULL) in _registry_check_code() (line 3102 of /var/www/includes/bootstrap.inc).

Seems to be working though -- thanks.

Just needed a slight tweak to fix the error in #16

Patch in #18 works great for me. Thanks!

Ah on second thoughts, this has issues with exportability:

     'node_only' => array(
       'node_changed' => 0,
     ),
+    'nodequeue' => array(
+      3 => '3',
+      2 => 0,
+      1 => 0,
+    ),
     'og' => array(
       'current' => 0,

That's the diff for my feature. The setting in the view handler should really be using the nodequeue machine name, rather than the local-only nodequeue ID.

The patch needs a small change to work with Nodequeue 7.x-3.x-dev

$subqueues = nodequeue_load_subqueues_by_queue(nodequeue_get_all_qids());

To

$subqueues = nodequeue_load_subqueues_by_queue(array_keys(nodequeue_get_all_queues()));

This patch is close to the same as #18, but instead of using internal id it is using nodequeue name as a key to enable exports using nodequeue name instead of internal id.

OR-clause is removed since it broke db-query if nodequeue updates were the only cache invalidation criteria.

SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ') OR c4 = '6') ORDER BY timestamp DESC' at line 1: SELECT timestamp FROM {views_content_cache} WHERE (() OR c4 = :c4_0) ORDER BY timestamp DESC; Array
(
    [:c4_0] => 6
)

Seeing as it was added to the D6 branch, it should be added to the D7 branch too.

+1

@jaydub, @rpsu:
Thanks for your patches, it seems the OR clause if necessary though.
Using the patch you gave in https://www.drupal.org/node/2407467#comment-11535899 fixes the issue properly.

Bear in mind that patches #26 and #27 include the change from #2407467: views_content_cache_update_get() builds incorrect query, those to want to apply the patches separately need to use the one in #22

Adding a patch that includes #22 and the clause_mode method to make sure combining diverse criteria to clear cache works but doesn't include #2407467: views_content_cache_update_get() builds incorrect query that needs to be applied independently.

Setting as RTBC

Works perfectly, please add this patch.

Works like a charm, thanks!

#22 and #2407467: views_content_cache_update_get() builds incorrect query saved my day