okay, I thought I already put this in, but I can't seem to find it, so here goes again:

It would be great if you could specify the menu to place taxonomy_menus under. With 4.5's new menuing system, one can create multiple top level menus, and each will get it's own block for display. But taxonomy_menu.module only allows placement within the main Navigation menu.

I am proposing that on the admin/settings/taxonomy_menu page, the checkboxes be replaced with dropdown lists, containing:

-Do not display
-Navigation menu
-other menu from menu.module
-other menu from menu.module

This popup could be shown for each vocabulary, thus allowing admins to place their taxonomy_menus in their own blocks easily.

I'll see what I can come up with codewise, but I'm not sure I can handle it...

Comments

joshuajabbour’s picture

I've temporarily gotten around this issue by heading into phpMyAdmin, and manually changing the pid for the vocabulary menu item to the mid of the new menu I created in menu.module.

So it can be done, we just need a front end for it.

(you need to get around the menu cache after you do this. the easiest way is to disable and re-enable the vocabulary menu item from within menu.module)

joshuajabbour’s picture

another note.

while we are doing this, if might be nice to add the "Display descendants" on a per-vocabulary-menu basis. I don't know if this is possible, but...

The whole settings page could be put in a nice little table, like:

vocabulary name | parent menu | display descendents?
-------------------------------------------------------------------------------
"vocabulary name" | drop-down | checkbox
"vocabulary name" | drop-down | checkbox

Eric Scouten’s picture

Actually, I'm not sure why anything new is needed. With the new menu admin system, you can hack up a taxonomy_menu and send it all over the menu system if you want to. (I've been doing it for a new site I'm building.)

If anything, I would argue the opposite: the checkboxes for "Display (vocabulary name)" should be removed because they duplicate behavior under administer >> menus.

joshuajabbour’s picture

>Actually, I'm not sure why anything new is needed. With the new menu admin system, you
>can hack up a taxonomy_menu and send it all over the menu system if you want to. (I've
>been doing it for a new site I'm building.)

I don't believe you can move the top-level vocaulary menu item to another (new, non-Navigation) menu with the menu.module. I've tried. There is no option when you edit the Vocabulary menu item; all you can do is change the name.

As I said, the parent menu can be changed via phpMyAdmin, but currently not with the menu.module interface. And yes, I agree, it would be better to do it in menu.module, but it can't be done now. Maybe that's a bug in menu.module; I'm not sure.

[Actually, I just tried it by enabling a new taxonomy menu, and then heading to menu.module to adjust the settings. Yep, no option in Edit for the Vocab item, but then if I disable the Vocab item (which previously made every child item become top-level), funkiness now ensues. Regardless, I have never been able to adjust the parent of the Vocabulary menu item, and this is what is necessary in order to move the menu.]

>If anything, I would argue the opposite: the checkboxes for "Display (vocabulary name)"
>should be removed because they duplicate behavior under administer >> menus.

In a way, they duplicate behavior handled by menu.module, but in another way, they don't. The checkboxes in taxonomy_menu admin determine *whether or not taxonomy menus are even setup for a Vocabulary in menu.module*.

It would be a mistake to automatically make menus for every Vocabulary, and then force the user to enable or disable them in menu.module. (In my case, I have eight vocabs with hundreds of terms, it wouldn't be fun to have to scroll through menu.module when I only want one vocab to have a menu available.)

Using menu.module's functionality to alter the menus is fine, but there should be a way to tell taxonomy_menu.module whether or not to ever make a menu for a Vocabulary.

Concluding, I think taxonomy_menu should retain the ability to enable/disable menus for each Vocabulary, and either allow the parent menu to be set, or ideally, allow menu.module to alter the parent menu for each vocabulary.

morbus iff’s picture

Assigned: Unassigned » morbus iff

Closing. This is caused/fixed by the patch in http://drupal.org/node/12823.