Closed (fixed)
Project:
Subscriptions
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
13 Feb 2007 at 06:58 UTC
Updated:
16 Mar 2007 at 08:00 UTC
Jump to comment: Most recent file
Some features weren't available.
Tracked it down to the subscription module permissions available (via subscriptions_perm()) being different than those requested (by various user_access($permission) calls in the subscriptions module).
Reviewed what permissions were requested by the subscription module through various user_access($permission) calls and updated the array of permissions returned by subscriptions_perm().
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | tax_perm.patch | 1.02 KB | i10neorg |
| #1 | subscriptions.module_permissions_2.patch | 738 bytes | i10neorg |
| subscriptions.module_permissions.patch | 738 bytes | i10neorg |
Comments
Comment #1
i10neorg commentedOops, I think my patch was reversed, sorry.
Use this patch or
patch -R.Comment #2
i10neorg commentedOh yeah, the patch is against subscription.module version 1.62.2.20 .
Sorry I'm so bad at this, this is my first patch (obviously!).
Comment #3
arthurf commentedNot bad at this at all. Thanks for taking the time to make a patch.
I changed your patch slightly as I was trying to make sure that the user access language was more clear. Thanks for finding this discrepancy. I do most of my testing with the root user, which I over looked this. Woops!
Comment #4
i10neorg commentedThe taxonomy permission is still not right (in subscriptions.module 1.6.2.23).
Both "subscribe to taxonomy" and "subscribe to taxonomy terms" are mentioned, but I'm guessin only one was intended. "subscribe to taxonomy" is checked for in two
node_access()calls, and "subscribe to taxonomy terms" is present insubscriptions_perm().I guessed "subscribe to taxonomy terms" was preferred, so I tried updating the references to "subscribe to taxonomy" in
node_access(), but access was denied to the path "subscriptions/taxonomy" for some reason I could not find ("user/uid/subscriptions/taxonomy" worked).So, I changed "subscribe to taxonomy terms" in
subscriptions_perm()to "subscribe to taxonomy", and both routes to updating taxonomy ("subscriptions/taxonomy" and "user/uid/subscriptions/taxonomy") seemed to work.The patch just replaces "subscribe to taxonomy terms" with "subscribe to taxonomy" in
subscriptions_perm().Comment #5
i10neorg commentedComment #6
mindless commentedChanged the 2 user_access calls to 'subscribe to taxonomy terms'. Maybe you had trouble with this change due to cached menu items? Make sure access control is setup ok and maybe try a new user to test this.
Comment #7
(not verified) commented