Hi :) I love this theme!

Currently, I have one client using a slightly modified version of this theme on D6 and we are in the process of upgrading to D7. I installed the D7 version onto my localhost so that I could get the modifications correct and am noticing that the admin overlay is not appearing correctly. I did make a screenshot so that you can see what I mean. Note the scroll bar on the right has already been moved some so that you can see the top of the "Appearance" overlay where you would choose and configure the theme. I am using "Seven" as the administrative theme.

When I click on any of the admin menu items, the overlay comes up far down the page, I have to scroll down to see anything. I tried adding to the style.css to see if I can override the overlay positioning from within the theme but it doesn't seem to work.

CommentFileSizeAuthor
screenshot-appearance.jpg96.94 KBFanaile

Comments

ishmael-sanchez’s picture

Assigned: Unassigned » ishmael-sanchez
Status: Active » Needs work

Ok so I have to admit I'm not a fan of the overlay so when I developed the d7 version there wasn't testing for that. Anyway so it looks like the overlay uses the toolbar position when rendering so it adds inline styles using JS that's why you have to scroll to see the content and you can't override it.

A simple fix is to remove the code on style.css around line 335

.toolbar #toolbar {
  bottom:0;
  top:inherit;
}

The reason this was included is because the main menu uses a fixed position and so does the toolbar so you can't see your main menu. If that's not a big deal go ahead and remove those rules.

Another option would be to replace that code with

#toolbar {
  top:10%;
}

This lets your main menu peak out but the toolbar is kinda in an annoying spot. Let me know what you think.

ishmael-sanchez’s picture

Status: Needs work » Fixed

Ok so people should be using a different admin theme and ideally I recommend using admin_menu instead of the core tool bar.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Fanaile’s picture

Hi Ishmael;

Thank you so much for your reply and very helpful answers; it took me a while to get back in here so that I could tell you that they helped tremendously and I appreciate your help :)

pitxels’s picture

I really like this theme, and I appreciate your contribution.

I can see you have your way to administer your sites, but I think the theme should use the standard toolbar on the top by default and not as a fix the user need to make. The drupal team have make a great effort on making drupal more usable and may documentation videos and documents teach how to use it in a standard way.

About admin menu I know it can save time, but It really looks overwhelming to final users to have all these links in front of them

I a a power user and designer can make myself a custom theme. But a final user will be totally lost with this settings (the toolbar on the bottom and the overlay hidden).

Thanks again

ishmael-sanchez’s picture

@pitxels glad you like it. Good point about administers sites thanks for your feedback see
http://drupalcode.org/project/earthish.git/commit/fc05d93. You can use the dev snap shot for now until I push out another release or simply modify your sub theme.

I left the code for placement just in case someone does want to use it or copy to their sub theme. Next time kindly reopen the issue if you think it merits a second look.