Tests for Javascript caching [#1186016]

Comment	File	Size	Author
#10	cache.patch	1.24 KB	dawehner
#4	1186016-d7-2.patch	2.44 KB	redndahead
#3	1186016-d7-1.patch	2.46 KB	redndahead
#2	1186016-cache-js.patch	2.04 KB	dawehner

Comment #1

merlinofchaos commented 12 June 2011 at 04:52

This needs to be fixed prior to -rc -- that kinda blows the caching up if we're not properly caching javascript.

Log in or register to post comments

Comment #2

dawehner

German

commented 12 June 2011 at 06:26

Status:

Active

» Needs work

Status	File	Size
new	1186016-cache-js.patch	2.04 KB

Here is a first version.

Log in or register to post comments

Comment #3

redndahead commented 12 June 2011 at 14:42

Status:

Needs work

» Needs review

Status	File	Size
new	1186016-d7-1.patch	2.46 KB

There is my take on it. Was able to get settings working also.

Log in or register to post comments

Comment #4

redndahead commented 12 June 2011 at 14:47

Status	File	Size
new	1186016-d7-2.patch	2.44 KB

White space cleanup.

Log in or register to post comments

Comment #5

redndahead commented 12 June 2011 at 18:10

dereine said in irc that the current patch looked good, but asked me to create a simpletest for this. I'm not quite figuring out how to do this, showing my simpletest knowledge. If anyone has a chance to pick this up before I can figure it out that would be great.

Log in or register to post comments

Comment #6

redndahead commented 13 June 2011 at 03:07

I've been working on the test for a while, but I'm not figuring it out. My guess is I need to enable a view that has caching turned on and sometime during the execution of that view add a drupal_add_js. So that get's cached. Run the view again with a different drupal_add_js() and test with an assertRaw to make sure the first javascript is being added and the second one isn't.

Anyone have ideas on how to do this?