Invalid marker content in ldapauth.module:461
* t("LDAP user with DN $dn has a naming conflict with non-LDAP user $account->name")
Should use the proper %dn tokens

Invalid marker content in ldapdata.module:268
* t(LDAP_USER_DATA_EDIT_TAB)
Should use a token, or else not be T-ed at all. a t() with only a token is silly too. Maybe the constant itself can be t-ed?

Invalid marker content in ldapgroups.module:109
* t('Name of the multivalued attribute which holds the CNs of group members, for example: '.LDAP_DEFAULT_GROUP_ENTRIES_ATTRIBUTE.'.')

Again: should use a %token, concanating strings like this is unacceptible.

In general: never put markup in t()-s. Its for the Theme layer to decide, not hte translation layer, how stuff should look.

Comments

kreaper’s picture

kreaper commented

This probably exists in 5.x also.

Bèr Kessels’s picture

Bèr Kessels commented
Version: 4.7.x-1.0 » master

Confirmed. version set to HEAD.

kreaper’s picture

kreaper commented

Committed to HEAD

kreaper’s picture

kreaper commented
Status: Active » Fixed
kreaper’s picture

kreaper commented

Bèr Kessels

can you confirm before I close out this bug?

kreaper’s picture

kreaper commented
Status: Fixed » Closed (fixed)
Bèr Kessels’s picture

Bèr Kessels commented
Status: Closed (fixed) » Active

Updated to HEAD, and ran the extrator.php, got these errors:

Invalid marker content in extractor.php:621
* t("Embedded $variable")

Invalid marker content in extractor.php:629
* t(embedded_function_call())

Invalid marker content in ldapgroups.module:39
* t('<p style="margin: 1em;">Configure the Drupal Roles mappings with the LDAP Groups below. <br />Only the <strong>activated</strong> LDAP Configurations are listed. Additional LDAP Sources may be configured/enabled in the '.l(t('LDAP Integration'),'admin/settings/ldapauth').' administration area. </p><p style="margin: 1em;"><strong style="color: red;">PLEASE NOTE</strong>: advanced configuration for this module can be set by editing the module\'s config file, located at <em style="font-style: normal; padding: 1px 3px; border: 1px solid #8888CC; background-color: #DDDDFF">modules/ldap_integration/ldap_integration/ldapgroups.conf.php</em> in your Drupal install.</p>')
kreaper’s picture

kreaper commented
Status: Active » Fixed

fixed and confirmed that there are no other extractor errors are occurring.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)