The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.pushTransaction is doing $this->transactionLayers[$name] = $name; and this function checks for if (isset($this->transactionLayers[$name])) yes rollback uses array_search. Slow, confusing (what's the array structure, again...?), ugly. Edit: no test needed as no functionality has changed and transactions have tests already.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | transactionLayers_stores_keys-1186582-4.patch | 647 bytes | albert volkman |
| transactionLayers_stores_keys.patch | 539 bytes | chx |
Comments
Comment #1
damien tournoud commentedThere is no small cleanup.
Comment #2
chx commentedYou mean there is no too small cleanup? I agree. Let's find a few whitespaces to delete :D
Comment #4
albert volkman commentedLooks good in core/lib/Drupal/Core/Database/Connection.php, but not in core/lib/Drupal/Core/Database/Driver/sqlite/Connection.php. This fixes that :)
Comment #6
albert volkman commentedOdd, that test didn't fail locally. Do I have to have my local site set up with sqlite to properly test?
Comment #7
chx commented#4: transactionLayers_stores_keys-1186582-4.patch queued for re-testing.
Comment #9
jhodgdonThis test failure is probably:
#1783656: Intermittent test failure in testBulkImportUpdateExisting
Comment #10
albert volkman commentedComment #11
albert volkman commented#4: transactionLayers_stores_keys-1186582-4.patch queued for re-testing.
Comment #12
albert volkman commentedNot completely up-to-snuff with OOP inheritance, so would this simply need to be removed from the sqlite implementation altogether?
Comment #14
jhedstromPatch still applies and makes sense.
Comment #15
alexpottCommitted 0dfd0ca and pushed to 8.0.x. Thanks!