Additional bookmark does not appear as filter

This does seam to be a bug.

I had a look at the 4.7 version and it does add all the created bookmarks as filters. But both the 5.x and HEAD version does not seem to do this.

I also got this error “Validation error, please try again. If this error persists, please contact the site administrator.” when adding the new views fields “Bookmark: User for bookmarks” and “Bookmark: Count for bookmarks”

That makes me think the views section of the 5.x version needs some attention. I don’t know much about the views module to really know why but since this was there and is not any more maybe the views module has changed and this module needs to be updated.

I think I found the problem. What I found is that when I added new bookmarks and then later installed another module the new bookmarks all of a sudden would appear as filters. Also when using the devel module I used the Empty cache page and the newly added bookmarks would appear.

So after a few min digging I found that the cache table need to get cleared so that records like cid=“views_tables:en” would get refreshed.

I have attached a patch that clears the views cache an submit of new bookmarks.

For those that don’t use patch’s all you need to do is:

Add this at line at line 264

global $locale;

And this at line 281

  cache_clear_all("views_tables:$locale", 'cache');
  cache_clear_all("views_arguments:$locale", 'cache');
  cache_clear_all("views_default_views:$locale", 'cache');
  cache_clear_all("views_with_inline_args:$locale", 'cache');
  cache_clear_all("views_style_plugins:$locale", 'cache');

So that the views_bookmark_form_submit() function now looks like this.

function views_bookmark_form_submit($formid, $form) {
  global $locale;
  
  if ($form['vbid']) {
    $vbid = $form['vbid'];
    db_query("UPDATE {views_bookmarks} SET title = '%s', mark = '%s', mark_long = '%s', unmark = '%s', unmark_long = '%s', roles = '%s', global = %d, teaser = %d WHERE vbid = %d", $form['title'], $form['mark'], $form['mark_long'], $form['unmark'], $form['unmark_long'], implode(',', array_filter($form['roles'])), $form['global'], $form['teaser'], $form['vbid']);
    db_query("DELETE FROM {views_bookmark_nodetypes} WHERE vbid = %d", $form['vbid']);
  }
  else {
    $vbid = db_next_id('views_bookmarks_vbid');
    db_query("INSERT INTO {views_bookmarks} (vbid, title, mark, mark_long, unmark, unmark_long, roles, global, teaser) VALUES (%d, '%s', '%s', '%s', '%s', '%s', '%s', %d, %d)", $vbid, $form['title'], $form['mark'], $form['mark_long'], $form['unmark'], $form['unmark_long'], implode(',', array_filter($form['roles'])), $form['global'], $form['teaser']);
  }

  foreach ($form['nodetypes'] as $nodetype) {
    if ($nodetype) {
      db_query("INSERT INTO {views_bookmark_nodetypes} (vbid, type) VALUES (%d, '%s')", $vbid, $nodetype);
    }
  }
  cache_clear_all("views_tables:$locale", 'cache');
  cache_clear_all("views_arguments:$locale", 'cache');
  cache_clear_all("views_default_views:$locale", 'cache');
  cache_clear_all("views_with_inline_args:$locale", 'cache');
  cache_clear_all("views_style_plugins:$locale", 'cache');
  drupal_set_message("Bookmark '$form[title]' has been saved.");
  drupal_goto('admin/build/views_bookmark');
}

Or you can just clear the cache manually every time you add a bookmark.

Here is an updated patch that also clears the views cache when bookmarks are deleted.
Same thing as before, just for the views_bookmark_delete_confirm_submit() function.

subscribing

views_invalidate_cache() is a much safer option, and I went with that. Commited to -dev.