there is no

so load_address_select does not know where to put the data it received from jQuery.post

CommentFileSizeAuthor
#12 1186914-addressbook.patch1.89 KBbwynants
#11 1186914-addressbook.patch1.91 KBbwynants
#7 addressbook-1186914.patch1.57 KBbwynants
#5 1186914-addressbook.patch1.57 KBbwynants
#3 adressbook-1186914.patch1.57 KBbwynants

Comments

bwynants’s picture

bwynants commented

messed up formatting....

there is no <div id="delivery_address_select"></div> so load_address_select does not know where to put the data it received from jQuery.post

bwynants’s picture

bwynants commented
Status: Active » Needs review

fixed by changing uc_order_pane_ship_to

    case 'edit-title':
      $output = ' <img src="' . base_path() . drupal_get_path('module', 'uc_store')
                . '/images/address_book.gif" alt="' . t('Select from address book.') . '" '
                . 'title="' . t('Select from address book.') . '" onclick="load_address_select(' . $form['order_uid']['#value'] . ', \'#delivery_address_select\', \'delivery\');" '
                . 'style="position: relative; top: 2px; cursor: pointer;" />';
      $output .= ' <img src="' . base_path() . drupal_get_path('module', 'uc_store')
                 . '/images/copy.gif" alt="' . t('Copy billing information.') . '" title="'
                 . t('Copy billing information.') . '" onclick="uc_order_copy_billing_to_shipping();" '
                 . 'style="position: relative; top: 2px; cursor: pointer;" />';
       $output .= '<div id="delivery_address_select"></div>';      <----- added

and uc_order_pane_bill_to

      $output = ' <img src="' . base_path() . drupal_get_path('module', 'uc_store')
                . '/images/address_book.gif" alt="' . t('Select from address book.') . '" '
                . 'title="' . t('Select from address book.') . '" onclick="load_address_select(' . $form['order_uid']['#value'] . ', \'#billing_address_select\', \'billing\');" '
                . 'style="position: relative; top: 2px; cursor: pointer;" />';
      $output .= ' <img src="' . base_path() . drupal_get_path('module', 'uc_store')
               . '/images/copy.gif" alt="' . t('Copy shipping information.') . '" title="'
               . t('Copy shipping information.') . '" onclick="uc_order_copy_shipping_to_billing();" '
               . 'style="position: relative; top: 2px; cursor: pointer;" />';
      $output .= '<div id="billing_address_select"></div>';     <----- added
bwynants’s picture

bwynants commented
StatusFileSize
new adressbook-1186914.patch1.57 KB

patch included

Status: Needs review » Needs work

The last submitted patch, adressbook-1186914.patch, failed testing.

bwynants’s picture

bwynants commented
Status: Needs work » Needs review
StatusFileSize
new 1186914-addressbook.patch1.57 KB

Status: Needs review » Needs work

The last submitted patch, 1186914-addressbook.patch, failed testing.

bwynants’s picture

bwynants commented
StatusFileSize
new addressbook-1186914.patch1.57 KB
bwynants’s picture

bwynants commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, addressbook-1186914.patch, failed testing.

bwynants’s picture

bwynants commented

i give up....

bwynants’s picture

bwynants commented
Version: 7.x-3.0-beta3 » 7.x-3.x-dev
Status: Needs work » Needs review
StatusFileSize
new 1186914-addressbook.patch1.91 KB

wrong version selected? last try

bwynants’s picture

bwynants commented
StatusFileSize
new 1186914-addressbook.patch1.89 KB

correct patch

tr’s picture

tr commented

Two things when using the testbot:

1) Testbot doesn't work on fixed point releases like 7.x-3.0-beta3. You must always provide a patch against the -dev release and specify the version appropriately.

2) Testbot doesn't work properly yet for projects that are dependent on other modules. Meaning Ubercart.

Looking at the test results in #3, #5, and #7, you can see that they failed because of 1).

Because of 2), the tests will eventually always fail for Ubercart. The important thing is to look at the results and see how far it got before it failed. In particular you need to check to see that the patch is applied properly.

bwynants’s picture

bwynants commented

thanks, i think i have the patch creation a little bit better under control now...

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Fixed

Committed, thanks for the patch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.