Download & Extend

Proximity/Distance field link to views argument

Project:Location
Version:6.x-3.x-dev
Component:Location_views
Category:feature request
Priority:normal
Assigned:edxxu
Status:closed (fixed)

Issue Summary

The patch will let Proximity/Distance field to use the latitude and longitude from the distance argument as the origin.

Comments

#1

Please review the patch!

AttachmentSizeStatusTest resultOperations
argument_origin-1187044-1.patch1.47 KBIgnored: Check issue status.NoneNone

#2

Status:needs review» needs work

A) The spacing of the second patch band doesn't follow the coding standards. ( http://drupal.org/coding-standards )

B) You can't assume it will be in $view->args[0]. You have to determine which argument is the right one first, in case the view has been configured with other arguments in front of the proximity/distance one.

#3

Status:needs work» needs review

Please review the patch,thanks!

AttachmentSizeStatusTest resultOperations
argument_origin-1187044-3.patch1.62 KBIgnored: Check issue status.NoneNone

#4

Status:needs review» fixed

Sorry about the wait!

Committed to 7.x-3.x and 7.x-4.x, thanks!
ff9c5b885743408e6219c1c01e22e4fe48eadd25
5c93a17f220d5e129a1483efc2fe93c35d769578

Note that there is a zipcode mode the argument can be in as well, and it doesn't handle this. But I wanted to get this patch in so skyred is happy ;)

Thanks.
--Brandon

#5

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#6

Status:closed (fixed)» reviewed & tested by the community

Can you also commit to 6.x-3.x, please?

#7

Status:reviewed & tested by the community» fixed

skyredwang told me in irc that it was actually meant for 6.x originally.
Committed there too.
81ac6d4d99c1e22954edb1ffbd607166a22a7831

#8

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.