Closed (fixed)
Project:
Restrict Login or Role Access by IP Address
Version:
6.x-3.x-dev
Component:
Code
Priority:
Major
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
13 Jun 2011 at 16:52 UTC
Updated:
2 Mar 2014 at 07:00 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Jean Gionet commentedsubscribe
Comment #2
james.wilson commentedThis will be completed once the new 6.x-3.x version has been adopted. The D7 release will be a port of the 6.x-3.x branch along with IPv6 support.
Comment #3
chriscalip commentedsubscribe. note to self: Restrict Login or Role Access by IP Address
Comment #4
spcalpo commentedMay I ask how the Drupal 7 port of this module is progressing?
I may be able to provide assistance coding and/or testing it, as I have a potentially great use for a module with that restricts roles via IP address/range.
Thanks!
Comment #5
dwalker51 commentedsubscribe...need this for blocking access to an intranet on a mainly open site...(yea...i know I can do it in other ways...but this would in my case be better)
Comment #6
dwalker51 commentedAny news?
Comment #7
bfsworks commentedYes Please let us know, this is very powerful and could open a lot of possibilities for private internal database solutions.
Comment #8
abasso commentedI have made a very straight forward port for drupal 7 for my personal use. I am happy to share if anyone needs it before development for the 6.x-3.x has been adopted (can't guarantee perfect functionality, but works for me so far). I'm also available to help with the port afterwards if needed! Thanks for the great job on the original code!
Comment #9
cossimo commentedsubscribe
Comment #10
stongo commentedCan I help out with development to fast track D7 release? I have some cycles I can contribute to speed up a D7/6.x-3.x release.
Comment #11
evanbarter commentedThis is a straight port of the 6.x-3.x branch to Drupal 7 and should apply cleanly. I haven't had time to do extensive testing but from a quick look all the existing functionality should be working.
Comment #12
googletorp commentedGenerally the patch in #11 looks really good.
I found one bug though, hook_perm is changed to hook_permission in d7
I also added the configure link on the module link.
Other than that the core functionality looks good - with these minor improvements I think this is RTBC.
Comment #13
googletorp commentedDisregard last patch as it had a line of debug code, that messes with the ip check.
Comment #14
panthar commentedHey Guys,
Let me review this patch myself, and check it in.
Thank you all for the contributions!
Comment #15
steverweber commentedHere is another patch that includes Drupal 7 support and a tab that Set role based on IP.
We are currently using this at our university and it would be nice to see it merged into master so we are not forked and can follow your module updates.
Thanks
Comment #16
stongo commentedCan you please create a dev release of this from patch in comment #11 ?
I also have wrote a sub-module based on patch 11 that denies access to the login pages completely to unauthorized ips (why give anyone a clue it's even a drupal site?)
A dev branch would be very helpful as it seems there's already patches rolling in.
I would be interested in contributing to a 7.x-2.x branch, that makes the module more oop/class driven. It would make extending the module much easier if some of the basic functionality was encapsulated in classes.
Comment #17
jpwester commentedsubscribe
Comment #18
panthar commentedHi, I added a 7.x-1.x branch, exactly as stongo has it, without the patch file. As best I can see the files are ready for d7 already, but if the patch is required try to get me a patch file that works, if possible, and I will apply it.
Thanks.
Comment #19
Leeteq commentedThere is still no 7.x branch on the project page, not even on the releases page, and not visible in the version drop-down here in this issue.
Comment #20
robin van emden commentedWe have started to use #15 - but would very much prefer it if the maintainer would create an 7.x branch. Can we help in any way to make this happen?
Comment #21
Anonymous (not verified) commentedI'd like to also throw in my hat for helping in any way possible to get this 7.x branch up and running. #15 works like a charm.
Comment #22
james.wilson commentedAlmost finished with D7 port, including IPv6 support. Will be releasing in the next few days.
Comment #23
btully commentedAny update on this james_g? It's been over a month since the last post. Many thanks for everyone's hard work on getting a D7 posted :)
Comment #24
Leeteq commentedEagerly awaiting... ;-)
The patches here are coming "from" ("against") 6.x-2.x it seems: so is the coming 7.x-dev going to be totally different from these, having both 6.x-3.x now and probably unrelased 7.x code from the maintainer, which also is possibly related to 6.x-3.x?
Comment #25
Battleskull commentedI have been testing #15 and it seems to be working. But I would prefer an official release with IPV6 support. Hope this project wasn't abandoned cause this is exactly what I've been looking for.
Comment #26
bettibio commentedI tried the patch in 15 but I can not run the filter for role, the user connects from any ip and maintains the permissions of the role. Filter for user working properly. Any suggestions?
Comment #27
rocketeerbkw commented#13 still applies cleanly to 6.x-3.x, and I've looked over it and tested (I think) all of the functionality, all works. Other than some coding standards things which can be fixed in follow up issue, looks good to me.
Since #15 adds new functionality, I'm voting#13 as RTBC for a straight drupal 7 port.
Comment #28
Leeteq commentedExciting developments, @rocketeerbkw is offering to pick up the maintenance of this module :-) Kudos!
Ref. #2130471: Offering to maintain Restrict Login or Role Access by IP Address
Comment #29
Leeteq commentedPS. There is some overlap with the Restrict_IP module, which could call for some collaboration.
Ref. #2175915: ip2country support - restrict selected roles to log in only from selected countries
https://drupal.org/project/restrict_ip
Comment #30
rocketeerbkw commentedSince There have been some changes to the 6.x-3.x branch (which I just pushed) the patch in #13 no longer applies cleanly. A very minor change but I've included a new patch, and will be pushing a new 7.x-3.x branch.
Expect a new dev release in the next 12-24 hours.