as soon as I enable the userpoints retroactive module I get the following in big red letters in the drupal admin status/update:

Notice: Use of undefined constant USERPOINTS_PERM_RETROACTIVE - assumed 'USERPOINTS_PERM_RETROACTIVE' in include_once() (line 5 of /home/xxxxxxxx/public_html/drupal/sites/all/modules/userpoints_contrib/userpoints_retroactive/userpoints_retroactive.module).

drupal core 7.2 with a long list of modules, primarily forum formattting ones.

since I don't really need to account a huge amount of pre-module install data, I've disabled it. Feel free to request additional info though I won't go into deep troubleshooting for this reason.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir’s picture

Title: undefined constant USERPOINTS_PERM_RETROACTIVE » Unported modules are not flagged as Drupal 7-incomaptible
Component: Code: userpoints_retroactive » Code

That module has not yet been ported to Drupal 7. Just like a number of other userpoints_contrib modules.

Something went wrong with the core compatibility flag, this module should be reported as incompatible with Drupal 7.

Re-targeting this issue.

Berdir’s picture

Ok, the problem is that the package script adds a core = 7.x to all modules, overriding the definition by us.

So we probably need to remove these modules.

patoshi’s picture

how can this be done?

boran’s picture

What is the status here? Can a git branch be created where we can start testing/porting some modules to 7.x-1.x?
I can help getting these run: votingpoints userpoints_badges userpoints_role_exempt userpoints_register userpoints_reset userpoints_invite

Berdir’s picture

I can't give you commit permission (I don't have enough rights for this project), but I'd suggest anyway that you should create an issue per module and post a patch.

If you need a git repository to track the port process, you could create a sandbox or host it on github or whatever. Still reviewing an actual patch is much easier thanks to the awesome Dreditor.

Roxpace’s picture

How is it going with this porting? I feel a big need for some of the contrib modules and not able to convert them myself, I feel this question has been hanging in the air a long time now. Thanks for any kind of response.

kreynen’s picture

Project: User Points Contributed modules » Userpoints Flag [D7]
Status: Active » Needs review
Berdir’s picture

Project: Userpoints Flag [D7] » User Points Contributed modules
Status: Needs review » Active

This issue was only related to userpoints_flags because it was part of Userpoints Contrib 7.x-1.x, it's not in any way related to your project.

gumdal’s picture

Component: Code » Code: userpoints_retroactive
Assigned: Unassigned » gumdal
Issue summary: View changes
Status: Active » Needs review
FileSize
9.45 KB
1.58 KB

I have provided a patch for Userpoints_Retroactive contributed modules. Following are the enhancements:

1. Ported the module to Drupal 7.
2. Added support for retroactive revisions.
3. Made provisions to store the timestamp of original node and revision.

Limitations:

1. Due to my limited Drupal 7 and PHP knowledge I had to hardcode $weight in userpoints_retroactive_nodes and userpoints_retroactive_revisions methods.
2. I have added a new $retainDate workflow in userpoints.module (In patch userpoints-retroactive-1187616-9-D7.patch)
3. Probably user will have to disable "Always use system time" in "Transaction Stamping" section of - admin/config/people/userpoints/settings

Enhanced and tested in local development environment - Everything is fine as per my observation and I will be updating the same to my Production environment. Appreciate if someone can further enhance my patches to address these limitations.

Status: Needs review » Needs work

The last submitted patch, 9: userpoints-retroactive-1187616-9-D7.patch, failed testing.

The last submitted patch, 9: User_Points_Contributed-Retroactive-1187616-9-D7.patch, failed testing.

gumdal’s picture

Status: Needs work » Needs review
FileSize
9.41 KB

Provided a possible PHP fix in the patch "User_Points_Contributed-Retroactive-1187616-9-D7.patch"

Status: Needs review » Needs work

The last submitted patch, 12: User_Points_Contributed-Retroactive-1187616-10-D7.patch, failed testing.