Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
theme
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
14 Jun 2011 at 01:37 UTC
Updated:
2 Dec 2011 at 17:08 UTC
Jump to comment: Most recent file
Comments
Comment #1
jordojuice commentedComment #2
jordojuice commentedPlease remove LICENSE.txt, that will be added when your project is promoted to full project. Thanks for your contribution and good luck!
Comment #3
sayela commentedThank you very much. Will do as directed.
Comment #4
sayela commentedLICENSE.txt issue fixed.
Comment #5
jordojuice commentedThanks! Someone will come along and review your theme, but to do so you want it to remain in Needs review. Check out the workflow for project applications http://drupal.org/node/532400 as it differs from other drupal.org issues.
Comment #6
joachim commentedPlease run this through Coder review.
Check also things like policy on author credit in code files.
Shouldn't this be left to a module?
Please check Drupal.org's licensing conditions.
Comment #7
sayela commentedRemoved floating button due to bugs and updated footer section of page.tpl to conform to Drupal.org's licensing conditions. Thank you very much joachim, for your input.
Comment #8
sayela commentedI have setup a demo site for the theme at http://demo.rhapsodicdesigns.com/talata/. Also find attached a much bigger screenshot of the theme. Thanks.
Comment #9
attiks commenteddemo site looks good, html is valid, but your indentation inside your css files are not consistent, so it makes it hard to read.
there's a reference to http:// www. drupalghana. com/ but it doesn't exist anymore?
why do you do this: drupal_add_js('http://ajax.googleapis.com/ajax/libs/jquery/1.3.2/jquery.min.js?ver=1.3.2', 'external');
Comment #10
sayela commentedHello attiks, thanks for your comments. I have dealt with the necessary issues you raised. As for "drupal_add_js('http://ajax.googleapis.com/ajax/libs/jquery/1.3.2/jquery.min.js?ver=1.3.2', 'external');", it was used to include jquery.min.js from Google but it is no more needed so i have taken it out of the template.php file.
Comment #11
sayela commentedBugs fixed as identified by attiks.
Comment #12
sreynen commentedThere are no bug reports in this queue.
Comment #13
sayela commentedThanks.
Comment #14
attiks commentedLooks good, I understand you want to add a link to your site, but I think it would be better to change it so people can disable it without having to alter the files. But this is my opinion, not mandatory.
Somebody else has to review this as well, since this is the first theme I reviewed ;p
Comment #15
gregglesIt appears you are working in the "master" branch in git. You should really be working in a version specific branch. Please see the documentation about release naming conventions and creating a branch in git.
Please take a moment to make your project page follow tips for a great project page. In particular, adding a screenshot would be very valuable.
It looks like page.tpl.php and maintenance-page.tpl.php have some spacing issues, you may be using tabs instead of two spaces.
Those are all suggestions and do not block an application from approval.
Thanks for your contribution, sayela! Welcome to the community of project contributors on drupal.org.
I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Comment #16
gregglesWhoops, forgot to mark fixed.
Comment #18
intentionalfallacy commentedI don' know why but on my drupal I can't manage the poll. I can't add a poll to second bar section. ;/ Any idea how to fix this?
Comment #19
sreynen commentedintentionalfallacy, Talata is now published as a full project, so you should open an issue in the queue on the project page here: http://drupal.org/project/talata
This issue is specifically about the project application, which is complete, so please do not add unrelated comments here.
Comment #19.0
sreynen commentedCorrected URL