Talata is a clean, simple theme with multiple layouts for Drupal 7 sites.

This theme comes with 1, 2 or 3 column layouts, table-less design, built-in drop-down menu, built-in PNG fix for Internet Explorer etc.

More features are being tested for integration soon.

http://drupal.org/sandbox/sayela/1185778
http://www.rocomsolutions.com

CommentFileSizeAuthor
#8 talata.png328.35 KBsayela
screenshot.png63.33 KBsayela

Comments

jordojuice’s picture

Status: Active » Needs review
Issue tags: +PAReview: Theme, +pdx-code-review
jordojuice’s picture

Please remove LICENSE.txt, that will be added when your project is promoted to full project. Thanks for your contribution and good luck!

sayela’s picture

Thank you very much. Will do as directed.

sayela’s picture

Assigned: Unassigned » sayela
Priority: Normal » Minor
Status: Needs review » Fixed

LICENSE.txt issue fixed.

jordojuice’s picture

Assigned: sayela » Unassigned
Priority: Minor » Normal
Status: Fixed » Needs review

Thanks! Someone will come along and review your theme, but to do so you want it to remain in Needs review. Check out the workflow for project applications http://drupal.org/node/532400 as it differs from other drupal.org issues.

joachim’s picture

Status: Needs review » Needs work

Please run this through Coder review.

Check also things like policy on author credit in code files.

		<div class="float-title"><iframe src="http://www.facebook.com/plugins/like.php?href=<?php $curr_url = check_plain("http://" .$_SERVER['HTTP_HOST'] .$_SERVER['REQUEST_URI']); echo $curr_url; ?>&amp;send=false&amp;layout=box_count&amp;width=58&amp;show_faces=false&amp;action=like&amp;colorscheme=light&amp;font&amp;height=60" scrolling="no" frameborder="0" style="border:none; overflow:hidden; width:58px; height:60px;" allowTransparency="true"></iframe></div>

Shouldn't this be left to a module?

			<p>Copyright &copy; <?php print date('Y') ?> <a href="<?php print $front_page ?>" title="<?php print $site_name ?>"><?php print $site_name ?></a> All Rights Reserved | Theme by <a href="http://www.rhapsodicdesigns.com" target="_blank">Rhapsodic Designs</a></p>

Please check Drupal.org's licensing conditions.

sayela’s picture

Assigned: Unassigned » sayela
Status: Needs work » Needs review

Removed floating button due to bugs and updated footer section of page.tpl to conform to Drupal.org's licensing conditions. Thank you very much joachim, for your input.

sayela’s picture

Assigned: sayela » Unassigned
StatusFileSize
new328.35 KB

I have setup a demo site for the theme at http://demo.rhapsodicdesigns.com/talata/. Also find attached a much bigger screenshot of the theme. Thanks.

attiks’s picture

Status: Needs review » Needs work

demo site looks good, html is valid, but your indentation inside your css files are not consistent, so it makes it hard to read.

there's a reference to http:// www. drupalghana. com/ but it doesn't exist anymore?

why do you do this: drupal_add_js('http://ajax.googleapis.com/ajax/libs/jquery/1.3.2/jquery.min.js?ver=1.3.2', 'external');

sayela’s picture

Hello attiks, thanks for your comments. I have dealt with the necessary issues you raised. As for "drupal_add_js('http://ajax.googleapis.com/ajax/libs/jquery/1.3.2/jquery.min.js?ver=1.3.2', 'external');", it was used to include jquery.min.js from Google but it is no more needed so i have taken it out of the template.php file.

sayela’s picture

Category: task » bug
Status: Needs work » Needs review

Bugs fixed as identified by attiks.

sreynen’s picture

Category: bug » task

There are no bug reports in this queue.

sayela’s picture

Thanks.

attiks’s picture

Status: Needs review » Reviewed & tested by the community

Looks good, I understand you want to add a link to your site, but I think it would be better to change it so people can disable it without having to alter the files. But this is my opinion, not mandatory.

Somebody else has to review this as well, since this is the first theme I reviewed ;p

greggles’s picture

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. Please see the documentation about release naming conventions and creating a branch in git.

Please take a moment to make your project page follow tips for a great project page. In particular, adding a screenshot would be very valuable.

It looks like page.tpl.php and maintenance-page.tpl.php have some spacing issues, you may be using tabs instead of two spaces.

Those are all suggestions and do not block an application from approval.

Thanks for your contribution, sayela! Welcome to the community of project contributors on drupal.org.

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

greggles’s picture

Status: Reviewed & tested by the community » Fixed

Whoops, forgot to mark fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

intentionalfallacy’s picture

Category: task » bug

I don' know why but on my drupal I can't manage the poll. I can't add a poll to second bar section. ;/ Any idea how to fix this?

sreynen’s picture

Category: bug » task

intentionalfallacy, Talata is now published as a full project, so you should open an issue in the queue on the project page here: http://drupal.org/project/talata

This issue is specifically about the project application, which is complete, so please do not add unrelated comments here.

sreynen’s picture

Issue summary: View changes

Corrected URL