Fixing many bugs in D7 port

Ok, I guess it is time, afterall.
But I didn't yet start the port. I'll be working on it now on, along with some other business of mine...
Thanks for your interest. I'll report back.

Subscribe!

I have branched to 7.x and submitted an initial dev release that is not working at the moment.
But I thought that, as I'm going a bit slow on this one, anybody's help would be appreciated.

http://drupal.org/node/1227134

I just committed a first working version. It will be downloadable as soon as it is packaged.
Probably needs more work and lot of testing.

Unfortunately D7 version is very far from being useful. I started posting separate issues, but I uncovered a whole slew of small code and function problems. Instead of squeezing them one by one I went at it all at once. Here's a patch that fixes already posted issues (#1883656: Errors when saving settings, settings not saved. #1883654: "Picture URI: ..." shows up on profile2 page unexpectedly) and a bunch of others.

With this patch module seems fully functional to me.

I smuggled a new hook_avatarapproval_competency_check() for allowing integration with other modules like avatar_selection.module which needs to let avatarapproval module know when a file is from an already approved list.

Please review and commit.

I'm bumping to critical as current 7.x-1.x-dev is badly broken.

I found one corner case and updated the patch. Also changed the hook_avatarapproval_competency_check() API to use hooked module name. See companion patch for Avatar Selection in #1906488: Couple code issues and integration with Avatar Approval module.

Ok, last pass did find couple more bugs in operation with Avatar Selection. All fixed in this one, all my manual tests have passed.

Please review and beat on it.

Thank you for your patch iva2k;
i've build a new one upon that.

Anyone looking for a 7.x version and/or upgrade_path, please have a look at #2099485: 7.x version incl upgrade path - ready for testing