Task plugin for 'node/%node/draft' and 'node/%node/revisions/%/view'

I've hit this problem too.
Subbing.

This issue may be relevant, in that it pertains to adding page manager defaults for workbench: #1103638: Task plugin for 'admin/workbench'

Its not inclusive of workbench moderation but I would guess that similar work would be required.

I too am having his problem.

Yes, what we'd need is a task plugin to allow Page Manager to act on the path "node/%node/draft." Patches welcome.

It would look a lot like the patch I wrote in #1103638: Task plugin for 'admin/workbench'

I've run up against this problem as well.

This isn't the most robust of solutions, but to get it working in my environment for now I changed the workbench_moderation_node_view_draft function in workbench_moderation.node.inc from

function workbench_moderation_node_view_draft($node) {
  $current_node = workbench_moderation_node_current_load($node);
  return node_page_view($current_node);
}

to

function workbench_moderation_node_view_draft($node) {
  $current_node = workbench_moderation_node_current_load($node);
  if (module_exists('page_manager'))
  	return page_manager_node_view_page($current_node);  //defined in ctools/page_manager/plugins/tasks/node_view.inc
  else
	return node_page_view($current_node);
}

At least, it seems to be working so far - my panel page drafts are showing up in panels and my non-panel page drafts aren't breaking.

That's an interesting approach and I imagine it helps to get around the the need to recreate a Panels layout at node/%node/%draft. I wonder if we could get that benefit in the task handler approach so as to avoid module_exists().

I don't consider this a 1.0 blocker but it seems like we should figure this out so wb and panels play well together. I'm going to mark this Critical and see what happens.

The code in #5 works with some small edits, BUT if you you will get the wrong context, so if you using any context in your panel, they will be the current published node.

function workbench_moderation_node_view_draft($node) {
  $current_node = workbench_moderation_node_current_load($node);
  if (module_exists('page_manager')) {
    ctools_include('node_view', 'page_manager', 'plugins/tasks');
    return page_manager_node_view_page($current_node);  //defined in ctools/page_manager/plugins/tasks/node_view.inc
  }
  else {
    return node_page_view($current_node);
  }

}

We have to create a diffrent context that will load a node with a specific vid.

I wrote a task plugin it works. I asked in IRC the best way to cleanly reuse the task handler (Panels) definition from node/%node inside of this task plugin. Merlinofchaos gave me a much simpler and better answer. He said that workbench_moderation_node_view_draft() should directly reuse whatever page callback is used at node/%node.

So the task plugin isn't necessary for the use case discussed in this thread. I've included it in the patch because I had already written it and there is a different use case for it. One could use it if there was a need for different Panels layouts at node/%node vs node/%node/draft.

In reviewing this patch please look at the way I use menu_get_item(). Should we be responding to more than include_file and page_callback?

Also to write the task plugin I did a lot of copy/past find/replace. Are there any strings that need to be updated yet?

Take a look at http://drupal.org/project/workbench_panels

@anon: Rather than creating a separate module that will eventually be deprecated, it would be really great if you could help review this issue here.

The patch in #9 works fine, and I have used that patch and added support for node revisions aswell.

I will ask someone to remove workbench_panels when this issue is fixed.

I can take a look at this patch.

Interested in solutions here, thank you to people working on this problem which I also just ran into. Subbing.

subscribe

I can't get any of these solutions to work. The patch in #13 applies cleanly but I don't see new override options in page manager. I looked at workbench_panels, and did see the override options after installed it, but after creating overrides for node draft and node revision forms, I still didn't see those layouts presented when I went to the draft/revision creation pages in question. Am I missing something?

subscribe

This patch works for me. Elly you may need to clear your caches to see the options at admin/structure/pages

http://drupalcode.org/project/workbench_moderation.git/commit/8843ba019c...

Used the wrong status in the last comment.

hi
Please i would like to know if it has been added to workbench_moderation module?

thanks

yes in dev as mentioned in comment #21 @delacosta456. It will likely make it into the next release if no security stuff jumps ahead