Closed (fixed)
Project:
Quick Tabs
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
14 Jun 2011 at 21:06 UTC
Updated:
20 Jul 2011 at 17:51 UTC
Just tried setting my qt to the new accordion type.
http://awesomescreenshot.com/068ev8zeb
Instead of resizing when switching panes each one ended up being as tall as the tallest pane in the qt.
Comments
Comment #1
katbailey commentedHmm, this requires a specific setting to be passed in to the accordion widget, i.e.
autoHeight: false. So the real issue here is allowing options to be stored per renderer type. I guess we'll just have to add one more field to the Quicktabs table that stores a serialized blob of options, or else put everything in the renderer field. Needs some thought...Comment #2
katbailey commentedOK, the more I think about this the more I realise it is really needed. Shouldn't be a big deal though - the QuickRenderer class will have an optionsForm() method that returns form elements for capturing renderer-specific options (using the #states property we can make sure they aren't visible unless that renderer is selected) - these get stored as a serialized array in a new options field in the Quicktabs db table.
I definitely want this in the next alpha release and will hopefully get to it at the weekend.
Comment #3
bryancasler commentedI see you working on this in Git. Thanks so much!
Comment #4
katbailey commentedYep, try it out - there's an update hook to get the options field, and then if you already have a QT instance set up as accordion, you'll need to resave it because if you don't pass the "autoHeight: false" option, it defaults to true. I haven't added any other options yet but the main thing is having the mechanism there and then any renderer can add whatever options it needs.
Comment #5
katbailey commented