Changing location of password tab in password_policy_password_tab has broken functionality in password_policy [#1189756]

Several places in the password_policy.module make reference to the location of the password_policy_password_tab's password tab were not updated when that module was updated to place the password tab under the 'edit' path.

#1
Issue: Once your password has expired, you are not able to navigate to the password tab to make the change.
In password_policy_init(), line 34 needs to be changed from:

$change_password_url = 'user/'. $account->uid .'/'. (module_exists('password_policy_password_tab') ? 'password' : 'edit');

to:

$change_password_url = 'user/'. $account->uid .'/edit'. (module_exists('password_policy_password_tab') ? '/password' : '');

#2
In password_policy_user(), line 307 needs to be changed from:

drupal_goto('user/'. $account->uid .'/'. (module_exists('password_policy_password_tab') ? 'password' : 'edit'), $destination);

to:

drupal_goto('user/'. $account->uid .'/edit'. (module_exists('password_policy_password_tab') ? '/password' : ''), $destination);

#3
In password_policy_mail_tokens(), line 620 needs to be changed from:

'!edit_uri' => url('user/'. $account->uid .'/'. (module_exists('password_policy_password_tab') ? 'password' : 'edit'), array('absolute' => TRUE)),

to:

'!edit_uri' => url('user/'. $account->uid .'/edit'. (module_exists('password_policy_password_tab') ? '/password' : ''), array('absolute' => TRUE)),

Comment	File	Size	Author
#12	change-password-link-fix-1189756-12.patch	756 bytes	artkon
#11	change-password-link-fix-1189756-11.patch	717 bytes	artkon
#1	cannot-change-password-expired-1189756-2.patch	2.12 KB	draenen

Comments

Comment #1

draenen commented 16 June 2011 at 17:41

Status:

Active

» Needs review

Status	File	Size
new	cannot-change-password-expired-1189756-2.patch	2.12 KB

The attached patch makes the changes listed above.

Comment #2

ataxia commented 21 June 2011 at 14:05

Immediately after installing and configuring this module, I was locked out and unable to change my password. I made these changes manually rather than installing the patch, and they worked great.

Thanks!

Comment #3

draenen commented 24 June 2011 at 14:31

Did the patch fail?

Comment #4

technikh commented 22 September 2011 at 21:35

Thanks for the patch. the patch worked for me.

patch -p0 < cannot-change-password-expired-1189756-2.patch
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/password_policy.module b/password_policy.module
|index 54942ff..bc8e9eb 100644
|--- a/password_policy.module
|+++ b/password_policy.module
--------------------------
File to patch: password_policy.module
patching file password_policy.module