Closed (fixed)
Project:
Node revision reference
Version:
6.x-1.4
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
15 Jun 2011 at 23:15 UTC
Updated:
14 Mar 2012 at 04:10 UTC
Jump to comment: Most recent file
Comments
Comment #1
danielb commentedI was unable to apply your patch
Comment #2
kevin.mcnamee@mailbox.org commentedHi,
nothing wrong with the patch as far as I can see. Git seems to have a problem handling a new line at the EOF is all. I have rerolled the patch without the new line.
I was unsure how to get a new file into the diff, so I have just touched the revisionreference.token.inc file in the original directory first. You can do the same if Git complains about that too.
I am unfortunately working in Solaris using just vi and diff tools in case this all seems a bit retarded.
/Kevin
Comment #3
danielb commentedI could probably add that in manually.
I think whatever technique you're using to do patches, shouldn't require you to create a folder such as 'revisionreference_new'. That's how I did it back in the CVS days, but in git I just change the checked out code and diff it against what's on the server, which is the default that the diff command does.
Comment #4
kevin.mcnamee@mailbox.org commentedI'll start doing that from now on I think.
Comment #5
danielb commentedComment #6
danielb commentedI've simplified the code a bit and added it into 6.x, but I have not ported it to Drupal 7, someone will have to make an issue for that and provide the code.