One that comes to mind is -strip. I'm sure there are others, thus having this be a text box sounds like a good idea.

CommentFileSizeAuthor
#4 imageapi-1189884-4.patch1.77 KBmikeytown2
#2 imageapi-1189884-2.patch1.66 KBmikeytown2
#1 imageapi-1189884-1.patch1.65 KBmikeytown2
#1 bad.jpg576.78 KBmikeytown2

Comments

mikeytown2’s picture

mikeytown2 commented
Status: Active » Needs review
StatusFileSize
new bad.jpg576.78 KB
new imageapi-1189884-1.patch1.65 KB

Escaping the -command doesn't work as it adds in ' around the command then. De-saturate does work with the example if your wondering.

I've also attached a bad jpg file as an example of what can happen if these extra parameters are not passed along. Notice the file size in comparison to the dimensions; try viewing the file in IE8.

mikeytown2’s picture

mikeytown2 commented
StatusFileSize
new imageapi-1189884-2.patch1.66 KB

using escapeshellcmd()

drewish’s picture

drewish commented

So the description should probably make it clear that each option needs to be on its own line... assuming it really makes sense to force them onto their own lines. It might also be worth making it clear that these options will be passed to *every* usage of ImageMagick.

mikeytown2’s picture

mikeytown2 commented
Title: Allow for a custom code to be inserted into the convert command before it is ran » Allow for custom code to be inserted into the convert command before it is ran
StatusFileSize
new imageapi-1189884-4.patch1.77 KB

[tangent]
If we decide to support IMagick Having one command per line might allow us to more easily convert the settings over.
http://php.net/imagick-setcolorspace
http://php.net/imagick-setimagetype
http://php.net/imagick-stripimage

IMagick would probably allow for more complex transformations like Smart Sharpening. My take on this: http://www.autoitscript.com/forum/topic/85891-imagemagick-batch-jpg-proc...
[/tangent]

Here is the updated patch that better explains what is going on in the description. BTW I'm perfectly fine with using a textbox and putting this all on one line.