filefield_get_file_reference_count() counts references. If I understand the API right, we only need to report if there are any references, exact number doesn't matter. Thus we must be able to use range query with LIMIT 1
instead of COUNT which is painfully slow on innodb.

CommentFileSizeAuthor
#2 filefield_get_file_reference_count_1189932.patch2.36 KBcrea

Comments

crea’s picture

crea commented

Approach is already implemented in D7
http://drupal.org/node/747464

crea’s picture

crea commented
Status: Active » Needs review
StatusFileSize
new filefield_get_file_reference_count_1189932.patch2.36 KB
quicksketch’s picture

quicksketch
he/him
commented

Hmm, I don't know about this. This is a pretty major change to the API that has existed for almost 3 years, I don't think we can change it at this point to have a different return value. Who knows how other modules have been using these functions?

crea’s picture

crea commented

We can keep this function, but implement a copy with a different name which uses the new approach, and use it everywhere in this module (such as inside hook_file_references()). It's then a problem in calling module, if it calls the old function.

crea’s picture

crea commented
Issue tags: +Performance

tagging

pwolanin’s picture

pwolanin commented
Category: Feature request » Bug report
Issue summary: View changes
Status: Needs review » Needs work

Based on comments above, this is needs work to add a new function and convert internal uses.