When I have a single image in a views slideshow with jcarousel thumbs the next and previous links in the controls section do not work properly. If a person clicks on either of these links when there is only one picture in the slideshow the link takes them to a page like example.com/#

CommentFileSizeAuthor
#1 1190540-controls-bug.patch838 bytesnisaak

Comments

nisaak’s picture

nisaak commented
StatusFileSize
new 1190540-controls-bug.patch838 bytes

I made a change to the views_slideshow_jcarouselthumbs.theme file to add a check before adding the controls. I figured that if there is only one image in a slideshow then the controls section isn't terribly useful to show anyway, so I added a check to see if there was only 1 image in the slideshow and if so, not add the controls to the slideshow header or footer.

I tested this on one of my websites where I was running into this problem and it appears to be working.
Page with multiple images in slideshow - http://civilianpublicservice.org/camps/1/1
Page with single image in slideshow - http://civilianpublicservice.org/camps/20/1

This is my first attempt at a patch, so if something needs to be changed please let me know.

fearlsgroove’s picture

fearlsgroove commented
Status: Active » Fixed

thanks, committed

http://drupalcode.org/project/views_slideshow_jcarouselthumbs.git/commit...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.