Download & Extend

Stray reference to pm_disable

Project:Privatemsg
Version:7.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review

Issue Summary

The pm_disable table has been removed, but is still referenced in privatemsg_user_cancel(), causing errors when cancelling user accounts. Patch attached.

AttachmentSizeStatusTest resultOperations
privatemsg_delete_pm_disable.patch402 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 37,038 pass(es).View details | Re-test

Comments

#1

Status:active» needs review

#2

Status:needs review» fixed

Strange, why didn't my tests catch this...

Commited.

#3

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#4

Version:7.x-2.x-dev» 7.x-1.3
Status:closed (fixed)» active

This bug has now migrated to the production release of 1.3.

I fixed it by wiping out the whole section of code referring to pm_disabled but if someone could commit a better fix that would be great

#5

Version:7.x-1.3» 7.x-2.x-dev
Status:active» closed (fixed)

No, it has not. That table exists there, this is not supposed to be removed.

#6

Status:closed (fixed)» needs review

Then what is required to eliminate the error showing that the table pm_disable does not exist. I started on D7.0 and have upgraded periodically up to the current release 7.19. Been using privatemsg.module ever since, the update.php script has never attempted throughout anything to create or handle such a table, even when I installed a fresh copy of privatemsg 7.x - 1.3. I skimmed the MySQL db and the table did not exist, went looking for answers and found this bugfix, and stripping that chunk of code seemed to fix the problem.

nobody click here