Repeated documentation of @defgroup actions in actions.inc file:
/**
* @defgroup actions Actions
* @{
* Functions that perform an action on a certain system object.
*
* All modules should declare their action functions to be in this group and
* each action function should reference its configuration form, validate, and
* submit functions using \@see. Conversely, form, validate, and submit
* functions should reference the action function using \@see. For examples of
* this see comment_unpublish_by_keyword_action(), which has the following in
* its doxygen documentation:
*
* \@ingroup actions
* \@see comment_unpublish_by_keyword_action_form().
* \@see comment_unpublish_by_keyword_action_submit().
*
* @} End of "defgroup actions".
*/
/**
* @defgroup actions Actions
* @{
* Functions that perform an action on a certain system object.
*
* All modules should declare their action functions to be in this group and
* each action function should reference its configuration form, validate, and
* submit functions using \@see. Conversely, form, validate, and submit
* functions should reference the action function using \@see. For examples of
* this see comment_unpublish_by_keyword_action(), which has the following in
* its doxygen documentation:
*
* \@ingroup actions
* \@see comment_unpublish_by_keyword_action_form().
* \@see comment_unpublish_by_keyword_action_submit().
*
* @} End of "defgroup actions".
*/
Comments
Comment #1
jhodgdonHuh. I wonder how that happened? It looks like the two docblocks are identical, so one of them should just be removed. Good project for a novice patch contributor. Not a problem in Drupal 7/8 either.
Comment #2
josevitalsoutoThe two docblocks are identical
I also wonder how this happened
Comment #3
ninizik commentedComment #4
xjmTracking to review a patch if one is submitted.
Comment #5
ninizik commentedFirst patch ever. Scared to death because I could make a mistake. ( Not even sure about this post and issue settings)
Comment #7
ninizik commentedI don't know what's wrong. I uploaded the patch ( I also use Git to create the patch) with the file attachment form.
Comment #8
xjmTry getting rid of the spaces in the patch name. :) Then when you re-upload it, you can set it back to Needs Review again for testbot to test it.
Comment #9
ninizik commentedLet's try again.
Comment #10
xjmLooks perfect! Thanks.
Comment #11
jhodgdonThanks for taking the time to learn how to make patches, and for making this patch! As a reminder, this is Drupal 6 only (it is not a problem in Drupal 7/8).
Comment #12
ninizik commentedStep by step.... so what is the next step? ;)
Change the status ?
Comment #13
xjm@ninizik: I reviewed the patch and set it to RTBC, and @jhodgdon (the docs maintainer) signed off on it. So we are done with the issue, and now it's up to the branch maintainer to commit it. :)
Comment #14
ninizik commentedSo now, I can find another patch for another issue :) Thanks a lot for your help !!
Comment #15
jhodgdon@ninizik: if you want to work on an issue with higher impact and faster commits, try Drupal 7/8 issues (hint, hint). :)
Comment #16
xjmShe's already working on a D8 one. ;)
Comment #17
gábor hojtsyThanks, committed, pushed.
Comment #19
josevitalsouto