Closed (fixed)
Project:
Localizer
Version:
5.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
14 Feb 2007 at 17:28 UTC
Updated:
18 Apr 2007 at 22:46 UTC
Jump to comment: Most recent file
test case:
Assume you view node/10
"Translations"
"create translation" (for language Greek lets say)
Don't save the translation node
Later on
browse to node/10
You press "Translations"
You press "create translation" (for Greek language again)
Don't save the translation node (again)
if you go to admin/content/node you have node/10 + 2 translations of node/10
is there any way to check before creating another node ?
I think the most logical would be to associate each node with its translation immediatelly after pressing "create translation"
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | localizer_6.patch | 20.3 KB | sun |
| #5 | localizer_5.patch | 20.38 KB | sun |
| #4 | localizernode.module.patch | 2.64 KB | sun |
Comments
Comment #1
Roberto Gerola commentedThe "problem" is the node cloning system.
It make a clone of the node, save it and then shows it.
Yes, the association is not yet saved at this level.
Yes, it is better save it immediately.
Thanks
Comment #2
hass commentedhowever this sounds to be a garbage creation system... but if i press cancel this shouldn't be saved... i think it is not a good behavior if something is saved i don't want to be save.
node_clone have such a feature you can manually activate... "create node if 'clone node' tab is clicked". I don't know who uses this stupid setting... another garbage system build in a module.
Comment #3
giorgoskRoberto take a look at this http://drupal.org/node/110294 discussion
if you ever want to do a custom copy function
Comment #4
sunJust wanted to let you know that I'm working on this issue. The attached patch contains the changes that have been made so far. It's not functional yet.
Comment #5
sun@Roberto: Here's the patch I was talking about.
Functionality is the same, but localizernode no longer creates a new node in front of submitting a translation.
Please test. Do not test on productive sites.
Would be glad to receive feedback as soon as possible, because we're currently working on major localizer improvements that need to be finished in the next days.
Comment #6
sunsmk-ka has reviewed and partially reworked the last patch.
I've tested it once again and this seems to be RTBC now.
Comment #7
sunCommitted to 5.x. Thanks smk-ka.
Comment #8
(not verified) commented