Super small thing...
I don't understand the purpose of turning the button a different color? It should just borrow the site's theme in terms of button color.
#block-feedback-form #feedback-submit {background-color: white;}
For example: I have blue buttons with white text and the CSS in this module changes the BG color but doesn't set the text color.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | feedback-1190872-9.patch | 278 bytes | tim.plunkett |
| #7 | feedback-1190872-7.patch | 231 bytes | tim.plunkett |
| #5 | feedback-1190872-5.patch | 437 bytes | tim.plunkett |
| #4 | feedback-1190872-4.patch | 268 bytes | tim.plunkett |
| #3 | dark-submit-text-1190872-0.patch | 227 bytes | doublejosh |
Comments
Comment #1
jody lynnPatches accepted.
Comment #2
sunThe overall reason for Feedback's style overrides is that the widget is very tight and small in terms of width and height, so default styles of most themes break the feedback widget entirely.
I don't think it makes sense to discuss and resolve this minor little detail separately though. We need to have a larger discussion and roadmap on the topic, and that lives here: #693880: Alternative UIs/themes
Comment #3
doublejosh commentedGotcha. Totally a detail thing.
Here's a patch to set the dark text color, since the background is white.
Just a more foolproof install.
(Hi Jody.)
Comment #4
tim.plunkettI think this is a reasonable short-term fix until #693880: Alternative UIs/themes is resolved.
Comment #5
tim.plunkettEr, rolled against the wrong branch. Sorry for the noise.
Comment #6
sunFor the sake of a stop gap fix, rather #3 is acceptable for me, since I've seen the feedback form widget really blow up and bail out on a couple of custom themes already. That's why these minimal style overrides exist in the first place, slightly tweaked for appearance in the widget (hence, the background).
Comment #7
tim.plunkettAdding more styles just makes it harder to get back to my custom theme's styles.
input[type="submit"]has no chance of beating#block-feedback-form #feedback-submitfor specificity, and having to redeclare the style is a pain.However, #3 is better than nothing, so if I can't convince you to use #5, here's a reroll.
Comment #8
sunWould love to hear @Jody Lynn's thoughts.
Comment #9
tim.plunkettOkay, so after testing on Garland, #5 went too far, but #7 doesn't really make sense either. This still fixes the real problem.
Comment #10
jody lynnI sit next to Tim so we're usually on the same page :)
I'm for removing that white background styling of the submit button (#9) unless we know of a reason we need it. I asked Tim to check the git log for it being added and he couldn't find a record. So he checked that removing it would not mess up core themes. #9 works for core themes, so I'm for it. Death to white button.
Comment #11
doublejosh commentedThanks for the attention to this little detail :)
Comment #12
sunokö :) Counter-arguments in #7 are compelling.
However, please note that in D6, this might lead to problems. In particular, considering existing sites.
In D7, it's probably less of an issue, since form buttons are always wrapped in a #type 'actions' container, so themes should have dedicated styles for that.
So RTBC for D7, but not sure about D6.
Comment #13
sunAlright, @tim.plunkett just clarified in IRC that this does not even exist in D7.
Thanks for reporting, reviewing, and testing! Committed to 6.x-2.x.
A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.