Download & Extend
Poormanscron » Issues

Use drupal_cron_run() (fixes FeedAPI compatibility problem and multiple simultaneous runs)

Posted by pwolanin on February 14, 2007 at 6:00pm
Project:Poormanscron
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

In 5.x and HEAD, you should be able to call this function and cut out a lot of your code: http://api.drupal.org/api/5/function/drupal_cron_run

Login or register to post comments

Comments

#1

Posted by Rob Loach on February 11, 2008 at 7:13am
Title:use API function to run cron» Use drupal_cron_run() function to run cron
Version:7.x-2.x-dev» 6.x-1.x-dev
Status:active» needs review

Testing would be much appreciated.

AttachmentSizeStatusTest resultOperations
poormanscron_drupal_cron_run.patch3.17 KBIgnored: Check issue status.NoneNone

#2

Posted by pwolanin on February 26, 2008 at 12:47am

quick skim looks good

#3

Posted by Leeteq on April 27, 2008 at 5:05am

Subscribing.

#4

Posted by Rob Loach on April 27, 2008 at 9:41am
Status:needs review» fixed

http://drupal.org/cvs?commit=113162

#5

Posted by Rob Loach on April 27, 2008 at 9:42am
Version:6.x-1.x-dev» 5.x-1.x-dev
Status:fixed» patch (to be ported)

Oops, this actually needs to be patched into 5.x-1.x-dev.

#6

Posted by gpk on December 17, 2008 at 3:21pm

#1 also needs to be applied to HEAD.

[update]

Also note that you currently need to use 6.x-1.x-dev to get this fix, it's not included in 6.x-1.0.

#7

Posted by gpk on April 12, 2009 at 1:11pm
Title:Use drupal_cron_run() function to run cron» Use drupal_cron_run() function to run cron (fixes FeedAPI compatibility problem)

Another note: this patch removes the ability of poormanscron to log the progress of cron runs (though it doesn't get rid of the static variable that controls this..). There is also an open core issue for this: #131536: Make cron watchdog more granular and informative.

Also changing title to reflect the fact that this patch enables poormanscron to work with FeedAPI, since using http://api.drupal.org/api/5/function/drupal_cron_run means that the cron_semaphore flag will automatically be set during the cron run.

#8

Posted by Dave Reid on April 20, 2009 at 5:42pm
Title:Use drupal_cron_run() function to run cron (fixes FeedAPI compatibility problem)» Use drupal_cron_run() (fixes FeedAPI compatibility problem and multiple simultaneous runs)

#9

Posted by Vacilando on July 21, 2009 at 5:21pm

It's not clear to me from the above -- has 6.x-1.x-dev been patched as well?
I'm troubled by the notorious multiple-mail Simplenews problem #361071: Use locking to eliminate duplicate emails from concurrent simplenews cron runs. ...

#10

Posted by luco on August 20, 2009 at 3:01pm

+1 here.... thanks

#11

Posted by amandajane on October 23, 2009 at 7:51pm

+1 here too

#12

Posted by Dave Reid on October 23, 2009 at 8:55pm
Status:patch (to be ported)» fixed

Backported to the 5.x branch and new releases created with this for both branches.

#13

Posted by System Message on November 6, 2009 at 9:00pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here