Use drupal_cron_run() (fixes FeedAPI compatibility problem and multiple simultaneous runs)

pwolanin - February 14, 2007 - 18:00
Project:Poormanscron
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

In 5.x and HEAD, you should be able to call this function and cut out a lot of your code: http://api.drupal.org/api/5/function/drupal_cron_run

#1

Rob Loach - February 11, 2008 - 07:13
Title:use API function to run cron» Use drupal_cron_run() function to run cron
Version:HEAD» 6.x-1.x-dev
Status:active» needs review

Testing would be much appreciated.

AttachmentSize
poormanscron_drupal_cron_run.patch 3.17 KB

#2

pwolanin - February 26, 2008 - 00:47

quick skim looks good

#3

DanielTheViking - April 27, 2008 - 05:05

Subscribing.

#4

Rob Loach - April 27, 2008 - 09:41
Status:needs review» fixed

http://drupal.org/cvs?commit=113162

#5

Rob Loach - April 27, 2008 - 09:42
Version:6.x-1.x-dev» 5.x-1.x-dev
Status:fixed» patch (to be ported)

Oops, this actually needs to be patched into 5.x-1.x-dev.

#6

gpk - December 17, 2008 - 15:21

#1 also needs to be applied to HEAD.

[update]

Also note that you currently need to use 6.x-1.x-dev to get this fix, it's not included in 6.x-1.0.

#7

gpk - April 12, 2009 - 13:11
Title:Use drupal_cron_run() function to run cron» Use drupal_cron_run() function to run cron (fixes FeedAPI compatibility problem)

Another note: this patch removes the ability of poormanscron to log the progress of cron runs (though it doesn't get rid of the static variable that controls this..). There is also an open core issue for this: #131536: Make cron watchdog more granular and informative.

Also changing title to reflect the fact that this patch enables poormanscron to work with FeedAPI, since using http://api.drupal.org/api/5/function/drupal_cron_run means that the cron_semaphore flag will automatically be set during the cron run.

#8

Dave Reid - April 20, 2009 - 17:42
Title:Use drupal_cron_run() function to run cron (fixes FeedAPI compatibility problem)» Use drupal_cron_run() (fixes FeedAPI compatibility problem and multiple simultaneous runs)

#9

vacilando - July 21, 2009 - 17:21

It's not clear to me from the above -- has 6.x-1.x-dev been patched as well?
I'm troubled by the notorious multiple-mail Simplenews problem #361071: Multiple emails revisited - 50% too many ...

#10

luco - August 20, 2009 - 15:01

+1 here.... thanks

#11

amandajane - October 23, 2009 - 19:51

+1 here too

#12

Dave Reid - October 23, 2009 - 20:55
Status:patch (to be ported)» fixed

Backported to the 5.x branch and new releases created with this for both branches.

#13

System Message - November 6, 2009 - 21:00
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.