So I have been scratching my head at an issue where the modal box was not closing for the main status update, but the FBSS Comment one would close fine. In examining the difference between the two I noticed that the FBSS Comment form was not caching in the cache_form table.

I'm running Pressflow 6.22 maybe this is why other people are not experiencing this. However simply by changing $form = array('#cache' => FALSE); to FALSE my problems were solved..

Included the patch if it is not needed to cache this form anyway.

CommentFileSizeAuthor
facebook_status-form-cache.patch692 bytesAtomicStudios

Comments

icecreamyou’s picture

icecreamyou commented
Status: Reviewed & tested by the community » Needs review

You should never mark your own patch "ready to be committed."

The patch looks reasonable to me -- chances are that cache line was copied from the main status update form and I just never deleted it -- but I will need to set aside some time to test this.

This issue is actually a duplicate of #1179148: Modal frame dialog box doesn't close but I am marking that one as a duplicate of this instead because this issue has a patch.

AtomicStudios’s picture

AtomicStudios commented

I thought I marked as Needs Review, that's odd it was late last night, sorry.

icecreamyou’s picture

icecreamyou commented
Status: Needs review » Fixed

Committed fix to dev. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Marko B’s picture

Marko B commented

Is this working correctly? I am having this configuration

FBSS 6.x-3.0+11-dev
Modal frame api 6.x-1.x-dev
Automodal 1.0

So, modal frame is called through automodal, but somehow it doesn't close when status is added. Did you try to run it with this config?