Node update: make type attribute optional

This seems like a good feature however as it stands I can set $node['type'] to be an empty string and it will try to use that value an !empty check would be more appropriate than isset. Also as this is a new feature can you add a test for this?

This still does not take into account that node type can be empty with the isset check. Plus there is no need to do an !array_key_exists($node['type'], $node_types)) check instead you can do an isset for this. This should be used as it is more performant.

This can simplified

    // Make submission of node type optional
    if (!isset($node['type']) || empty($node['type'])) {
      $node['type'] = $old_node->type;
    }
>

to

<?php
    // Make submission of node type optional.
    if (empty($node['type'])) {
      $node['type'] = $old_node->type;
    }

as empty will return false if the item does not exist or is ''.

Also you need to add periods after your comments.

The approach of making sure the node type is valid is a really good idea, once the above is done this should be good to go. I haven't run the tests yet but they look sane from an eyeball.

Thanks looks good.

if we can get a 6.x version that would be great.

I don't know where to put this notice:

Notice: Undefined variable: final_resource en services_edit_form_endpoint_resources_submit() (línea 396 de ~/sites/all/modules/services/plugins/export_ui/services_ctools_export_ui.class.php).

Grabbing to reroll this weekend

@Killua99 please raise a new issue as your post is not related to this issue at all thanks.

Ok then.

New version of the patch to allow updates to ignore type. As per normally I'll backport after d7 version is rtbc.

+++ b/resources/node_resource.incundefined
@@ -313,13 +313,18 @@ function _node_resource_update($nid, $node) {
+  // If no type is provided use the existing node type.
+  if (empty($node['type']) && isset($old_node->type)) {
+    $node['type'] = $old_node->type;
+  }
+
   // Validate the node. If there is validation error Exception will be thrown
   // so code below won't be executed.

I think there is no need to check whether $old_node->type is available as we did node_load before.

Also we can avoid checking whether content type is valid if we loaded it from old node:

<?php
// If no type is provided use the existing node type.
if (empty($node['type'])) {
   $node['type'] = $old_node->type;
}
else {
  // Validate the node. If there is validation error Exception will be thrown
  // so code below won't be executed.
  _node_resource_validate_type($node);
}
?>

Everything else I am happy with. Thanks for great work @sanduhrs and @marcingy!

Reroll with changes above

@marcingy, what do you think about attached patch. Code is just moved around but in my opinion looks bit clearer.

Looks good would like Kyle to commit this and give a once over - I'll happily roll a d6 version of the patch once this is committed.

Port it!

Reroll for d6

Would be nice to get this into 3.2 ;)

looks great.

actually this break in 6.x