Zebra striping one comment after another is working fine.

However, when using threaded comments, there currently doesn't seem to be a way to do zebra striping by thread. It would nice if each comment had a class that contained zebra information for it's parent thread, as well as the "indented" class.

This would eliminate the need for the extra DIV with the "indented" class, currently being used by child comments.

Currently with $zebra added to the class:

<div id="comments" class="comment-wrapper">
    <a id="comment-1"></a>
    <div class="comment comment-by-viewer clearfix even" about="/comment/1#comment-1" typeof="sioc:Post sioct:Comment">
      ...
    </div>
    <a id="comment-2"></a>
    <div class="comment comment-by-viewer clearfix odd" about="/comment/2#comment-2" typeof="sioc:Post sioct:Comment">
      ...
    </div>
    <div class="indented">
      <a id="comment-4"></a>
      <div class="comment comment-by-viewer clearfix even" about="/comment/4#comment-4" typeof="sioc:Post sioct:Comment">
        ...
      </div>
    </div>
    <a id="comment-3"></a>
    <div class="comment comment-by-viewer clearfix odd" about="/comment/3#comment-3" typeof="sioc:Post sioct:Comment">
      ...
    </div>
  <form class="comment-form" action="/comment/reply/16" method="post" id="comment-form" accept-charset="UTF-8">
    ...
  </form>
</div>

Proposed:

<div id="comments" class="comment-wrapper">
    <a id="comment-1"></a>
    <div class="comment comment-by-viewer clearfix comment-even thread-even" about="/comment/1#comment-1" typeof="sioc:Post sioct:Comment">
      ...
    </div>
    <a id="comment-2"></a>
    <div class="comment comment-by-viewer clearfix comment-odd thread-odd" about="/comment/2#comment-2" typeof="sioc:Post sioct:Comment">
      ...
    </div>
    <a id="comment-4"></a>
    <div class="comment comment-by-viewer clearfix comment-even thread-odd indented" about="/comment/4#comment-4" typeof="sioc:Post sioct:Comment">
      ...
    </div>
    <a id="comment-3"></a>
    <div class="comment comment-by-viewer clearfix comment-odd thread-even" about="/comment/3#comment-3" typeof="sioc:Post sioct:Comment">
      ...
    </div>
  <form class="comment-form" action="/comment/reply/16" method="post" id="comment-form" accept-charset="UTF-8">
    ...
  </form>
</div>

Comments

dixon_’s picture

dixon_
he/him
Primary language English
Location France
commented
Version: 7.2 » 8.x-dev
Priority: Normal » Minor

Personally, this sounds like an edge case that core should add a lot of complex logic for, to solve. Anyway, it's a valid feature request but applies to 8.x first.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Version: 8.0.x-dev » 8.1.x-dev

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Active » Postponed (maintainer needs more info)
Issue tags: +stale-issue-cleanup

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

smustgrave’s picture

smustgrave commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Since there's been no follow up as a feature request going to close this one out. Can always be re-opened.

Thanks!